Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Remove outdated multi-gpu dask-cudf overview from docs #6583

Closed
beckernick opened this issue Oct 22, 2020 · 9 comments · Fixed by #12095
Closed

[DOC] Remove outdated multi-gpu dask-cudf overview from docs #6583

beckernick opened this issue Oct 22, 2020 · 9 comments · Fixed by #12095
Assignees
Labels
dask Dask issue doc Documentation

Comments

@beckernick
Copy link
Member

We should remove https://docs.rapids.ai/api/cudf/stable/dask-cudf.html from the docs, as it is outdated and potentially confusing. Dask-cuDF is covered in other documentation.

@beckernick beckernick added doc Documentation Needs Triage Need team to review and classify labels Oct 22, 2020
@beckernick beckernick removed the Needs Triage Need team to review and classify label Oct 22, 2020
@harrism
Copy link
Member

harrism commented Oct 23, 2020

@rjzamora Is this your bailiwick?

@harrism harrism added the Needs Triage Need team to review and classify label Oct 23, 2020
@rjzamora
Copy link
Member

@rjzamora Is this your bailiwick?

It probably should be. I haven't dealt with documentation much in the past, but I'd be happy to give it more attention.

@kkraus14 kkraus14 added dask Dask issue and removed Needs Triage Need team to review and classify labels Oct 23, 2020
@rjzamora
Copy link
Member

Dask-cuDF is covered in other documentation.

@beckernick - I agree that the "Multi-GPU with Dask-cuDF" page should be removed. However, it doesn't seem that Dask-cuDF is very well documented in other places. Perhaps it makes sense for us to add a README to cudf/python/dask_cudf? The 10-min introduction does a nice job comparing cudf with Dask-cuDF, but I think it would be ideal to have a dedicated Dask-cuDF landing page with useful information. What do you think?

@beckernick
Copy link
Member Author

I think that's consistent with the general trend we're moving in @rjzamora . cuML did something similar for the Forest Inference Library. We should take care to note that Github SEO is not that good for files down in the tree, so we may want to replicate the information in actual hosted documentation

@github-actions
Copy link

This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@harrism
Copy link
Member

harrism commented Feb 17, 2021

@beckernick @rjzamora what should we do here?

@github-actions github-actions bot removed the rotten label Feb 17, 2021
@beckernick
Copy link
Member Author

We still need to remove this documentation and replace it with a simple summary + links out to other relevant documentation.

@rjzamora I see you closed #6665 due to it going stale. Would you recommend we continue from where that PR left off and expand the README with additional links and references?

@rjzamora
Copy link
Member

rjzamora commented Feb 17, 2021

I'm sorry for letting this issue and #6665 go stale - Totally my fault for not prioritizing documentation enough.

Would you recommend we continue from where that PR left off and expand the README with additional links and references?

Yes. I agree that the easiest approach is to open a fresh PR with the same changes, but to improve/expand the README.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

rapids-bot bot pushed a commit that referenced this issue Nov 10, 2022
This PR removes an outdated notebook for "Multi-GPU with Dask-cuDF" from the docs. Resolves #6583 with some of the changes from #6665.

See also: rapidsai/rapids.ai#256 (comment)

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Richard (Rick) Zamora (https://github.com/rjzamora)

URL: #12095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask Dask issue doc Documentation
Projects
None yet
5 participants