Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Upgrade clang-format to Clang 11 and other adjustments #5187

Closed
codereport opened this issue May 13, 2020 · 2 comments · Fixed by #6695
Closed

[FEA] Upgrade clang-format to Clang 11 and other adjustments #5187

codereport opened this issue May 13, 2020 · 2 comments · Fixed by #6695
Assignees
@codereport
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@codereport
Copy link
Contributor

We need to upgrade clang-format to Clang 11. While we are at it, we will make a couple other small adjustments to the clang-format config that were overlooked:

  • AllowShortLoopsOnASingleLine: false
  • PointerAlignment: Left (actually looks like this is already the case - don't know how I got confused)
@codereport codereport added feature request New feature or request code quality libcudf Affects libcudf (C++/CUDA) code. labels May 13, 2020
@codereport codereport self-assigned this May 13, 2020
@codereport codereport mentioned this issue Nov 6, 2020
Merged
6 tasks
@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@rapids-bot rapids-bot bot closed this as completed in #6695 Jul 7, 2021
rapids-bot bot pushed a commit that referenced this issue Jul 7, 2021
@codereport
Updating Clang Version to 11.0.0 (#6695)
7721819 
This resolves: #5187

PR description copied from: rapidsai/cuml#3121

Depends on: rapidsai/integration#304

This PR will upgrade the clang version required to 11.0.0 in order to enable us with running clang-tidy on .cu files, while running on cuda v11. See rapidsai/raft#88 for more details.

CI will not pass as the underlying conda-env still uses 8.0.1. Once we have the rapids-build-env meta package updated, this should pass.

-----

### Fixes from Clang 8.0.1 to Clang 11.0.0 (that are observed in delta)

* Missing spaces
* Incorrect alignment when ternary expression splits across multiple lines
* Comment alignment on macros
* Fixed where function signatures have line breaks
* Aligning macros
* Always left align pointer/reference
* Don't allow single line for loops

-----
To do list:

* [x] Update python file
* [x] Update conda environment files
* [x] Run formatter to apply all changes from upgrading
* [x] Add changes from #5187
* [x] Review list of new changes from 8.0.1 to 11; choose which to incorporate
* [x] Get working with RAPID compose

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Nghia Truong (https://github.com/ttnghia)
  - Mark Harris (https://github.com/harrism)
  - Dillon Cullinan (https://github.com/dillon-cullinan)

URL: #6695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codereport codereport

Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating Clang Version to 11.0.0 codereport/cudf
1 participant
@codereport