Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]need support 'product' method in cudf.Dataframe.groupby.agg #4882

Closed
pengsnv opened this issue Apr 13, 2020 · 2 comments · Fixed by #7763
Closed

[FEA]need support 'product' method in cudf.Dataframe.groupby.agg #4882

pengsnv opened this issue Apr 13, 2020 · 2 comments · Fixed by #7763
Assignees
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.

Comments

@pengsnv
Copy link

pengsnv commented Apr 13, 2020

When I try to use cudf.DataFrame.groupby.agg with 'product' method, it report an error.
steps to reproduce the error:

  1. start the container:
    nvidia-docker run -it --rm nvcr.io/nvidia/rapidsai/rapidsai:cuda10.1-runtime-ubuntu18.04
  2. run the following code:
    import cudf data=cudf.DataFrame({'a':[1,1,2],'b':[2,3,4]}) data.groupby('a').agg('product')
  3. the error is:
    Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/opt/conda/envs/rapids/lib/python3.6/site-packages/cudf/core/groupby/groupby.py", line 143, in agg result = self._groupby.aggregate(self.obj, normalized_aggs) File "cudf/_libxx/groupby.pyx", line 144, in cudf._libxx.groupby.GroupBy.aggregate RuntimeError: cuDF failure at: /conda/conda-bld/libcudf_1585640494801/work/cpp/src/aggregation/result_cache.cpp:88: Result does not exist in cache
    I find cudf.Dataframe.groupby.agg support 'product' in the source code aggregation.pyx , but it is not listed ingroupby.pyx

This is an important method in my customer's procedure. Can we support this method?

@pengsnv pengsnv added Needs Triage Need team to review and classify feature request New feature or request labels Apr 13, 2020
@kkraus14 kkraus14 added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. and removed Needs Triage Need team to review and classify labels Apr 13, 2020
@devavret devavret self-assigned this Jun 22, 2020
@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@devavret devavret assigned karthikeyann and unassigned devavret Mar 17, 2021
rapids-bot bot pushed a commit that referenced this issue Apr 21, 2021
closes #4882

Added groupby.product support in both hash and sort groupby.

Authors:
  - Karthikeyan (https://github.com/karthikeyann)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Jake Hemstad (https://github.com/jrhemstad)
  - https://github.com/brandon-b-miller

URL: #7763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants