Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QST/Discussion] Reorganize pytests #4730

Closed
ayushdg opened this issue Mar 28, 2020 · 4 comments
Closed

[QST/Discussion] Reorganize pytests #4730

ayushdg opened this issue Mar 28, 2020 · 4 comments
Assignees
@vyasr
Labels
proposal Change current process or code Python Affects Python cuDF API. tests Unit testing for project

Comments

@ayushdg
Copy link
Member

ayushdg commented Mar 28, 2020

The pytests directory currently has a flat structure: test/all_tests.
It might make sense to move tests to subfolders based on the operations/modules they might be most relevant to? Eg: All IO related tests can move to io/tests like the pattern followed by dask or to tests/io like pandas.
@ayushdg ayushdg added question Further information is requested Needs Triage Need team to review and classify labels Mar 28, 2020
@kkraus14 kkraus14 added code quality Python Affects Python cuDF API. proposal Change current process or code tests Unit testing for project and removed Needs Triage Need team to review and classify question Further information is requested labels Apr 7, 2020
@vuule
Copy link
Contributor

vuule commented Feb 3, 2021

I think for cuIO the preferable path would be tests/io/file_format so it's easier to selectively run groups of related tests from different files.
We can go ahead and make this change for cuIO tests in 0.19, unless there are objections to this structure.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@vyasr vyasr self-assigned this Jul 12, 2022
@vyasr vyasr mentioned this issue Jul 12, 2022
Merged
@vyasr
Copy link
Contributor

vyasr commented Jul 12, 2022

The plan for this will be discussed and decided upon in #11199

@vyasr vyasr mentioned this issue Oct 26, 2022
Open
12 tasks
rapids-bot bot pushed a commit that referenced this issue Nov 3, 2022
@vyasr
Add developer docs for writing tests (#11199)
eaa0706 
This PR adds documentation on how Python tests should be written.

Related to #4730. This PR will establish best practices. Follow-up PRs will be needed to implement them.

Resolves #6481.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Matthew Roeschke (https://github.com/mroeschke)
  - Lawrence Mitchell (https://github.com/wence-)
  - Ashwin Srinath (https://github.com/shwina)

URL: #11199
@vyasr vyasr mentioned this issue Jan 5, 2023
Merged
3 tasks
@vyasr vyasr mentioned this issue May 10, 2024
Open
@vyasr
Copy link
Contributor

vyasr commented May 10, 2024

Closing in favor of #15723, which is a bit updated and hopefully more discoverable.

@vyasr vyasr closed this as completed May 10, 2024
@vyasr vyasr mentioned this issue May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vyasr vyasr

Labels
proposal Change current process or code Python Affects Python cuDF API. tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vyasr @kkraus14 @vuule @ayushdg