Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] SUM_OF_SQUARES aggregation for groupby in libcudf #4667

Closed
shwina opened this issue Mar 24, 2020 · 4 comments · Fixed by #7362
Closed

[FEA] SUM_OF_SQUARES aggregation for groupby in libcudf #4667

shwina opened this issue Mar 24, 2020 · 4 comments · Fixed by #7362
Assignees
@karthikeyann
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@shwina
Copy link
Contributor

shwina commented Mar 24, 2020

It would be great if libcudf groupby could provide a SUM_OF_SQUARES aggregation.

Additional context
While Pandas does not have a sum_of_squares aggregation explicitly, it looks like the dask_cudf implementation of groupby.std could benefit from a sum_of_squares aggregation greatly (cc: @quasiben).
@shwina shwina added feature request New feature or request Needs Triage Need team to review and classify labels Mar 24, 2020
@shwina shwina added libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Mar 24, 2020
@quasiben quasiben mentioned this issue Mar 24, 2020
Closed
@karthikeyann
Copy link
Contributor

Adding SUM_OF_SQUARES in hash groupby causes ptxas compiler segfault. (similar to crash faced by @davidwendt)

cudf/cpp/src/groupby/hash/groupby.cu

Line 74 in 6828e2c

// FIXME(kn): adding SUM_OF_SQUARES causes ptxas compiler crash (<=CUDA 10.2) for more than 3 types!

@harrism
Copy link
Member

harrism commented Feb 9, 2021

If this does not happen in CUDA 11.x, then you can add it with an include guard to workaround the compiler issue.

@karthikeyann karthikeyann mentioned this issue Feb 10, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Feb 12, 2021
@karthikeyann
Add groupby SUM_OF_SQUARES support (#7362)
f3bf0e5 
closes #4667
- Add hash groupby SUM_OF_SQUARES support
- considering ptxas 10.2 crash, it's enabled for floating types only in unit tests.

Authors:
  - Karthikeyan (@karthikeyann)

Approvers:
  - Conor Hoekstra (@codereport)
  - Keith Kraus (@kkraus14)
  - Jake Hemstad (@jrhemstad)

URL: #7362
@karthikeyann karthikeyann self-assigned this Feb 12, 2021
@karthikeyann
Copy link
Contributor

Even with "closes" keyword in PR #7362 , this issue is not closed automatically!

@davidwendt
Copy link
Contributor

Even with "closes" keyword in PR #7362 , this issue is not closed automatically!

My understanding is that this only works if the PR's branch matches the default branch and our default branch is still 0.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karthikeyann karthikeyann

Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add groupby SUM_OF_SQUARES support karthikeyann/cudf
4 participants
@harrism @shwina @karthikeyann @davidwendt