Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Expand clang-tidy checks #17410

Open
21 tasks
bdice opened this issue Nov 21, 2024 · 0 comments
Open
21 tasks

[FEA] Expand clang-tidy checks #17410

bdice opened this issue Nov 21, 2024 · 0 comments
Labels
feature request New feature or request

Comments

@bdice
Copy link
Contributor

bdice commented Nov 21, 2024 •
edited
Loading

We discussed clang-tidy during the cuDF brown bag session today. We looked at a list of suggested clang-tidy checks from @vuule and @davidwendt. These clang-tidy checks had group consensus that we should try enabling them:

  • cppcoreguidelines-init-variables
  • cppcoreguidelines-narrowing-conversions
  • cppcoreguidelines-no-malloc
  • cppcoreguidelines-pro-type-member-init
  • cppcoreguidelines-slicing
  • cppcoreguidelines-rvalue-param-not-moved
  • cppcoreguidelines-virtual-class-destructor
  • bugprone-copy-constructor-init
  • bugprone-dangling-handle
  • bugprone-fold-init-type
  • bugprone-implicit-widening-of-multiplication-result
  • bugprone-move-forwarding-reference
  • bugprone-redundant-branch-condition
  • bugprone-return-const-ref-from-parameter
  • bugprone-too-small-loop-variable
  • bugprone-unchecked-optional-access
  • bugprone-use-after-move
  • misc-const-correctness
  • misc-definitions-in-headers
  • misc-use-anonymous-namespace
  • misc-use-internal-linkage

Once #17407 is merged, we can add these gradually over time. Please edit this checklist as checks are added!
@bdice bdice added the feature request New feature or request label Nov 21, 2024
@vyasr vyasr mentioned this issue Nov 23, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Dec 3, 2024
@vyasr
Apply clang-tidy autofixes from new rules (#17431)
d3e94d4 
This PR contains all of clang-tidy's autofixes for the rules outlined in #17410. In the process I simplified the process of performing autofixes locally.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Vukasin Milovanovic (https://github.com/vuule)
  - David Wendt (https://github.com/davidwendt)
  - Bradley Dice (https://github.com/bdice)

URL: #17431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bdice