-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] libcudf install does not install nvcomp dependency #16986
Comments
@KyleFromNVIDIA Could you take a look? |
Well, that is unfortunate. Luckily, this is only an issue for static builds, since nvcomp is a We may be able to add special logic to the cudf export file that, instead of calling |
I was with you up to the last part “based on the location of the shared library in the nvcomp wheel.” This should not affect wheel builds? This should only affect static libcudf builds, like those used by Spark — which have nothing to do with wheels. I think the issue is with the CPM-fetch code path, because we find nvcomp via conda packages or wheels for the other paths. |
Ah, you're right. In that case the solution is much simpler: provide an option in |
Describe the bug
After #16946 performing a cmake install of libcudf no longer installs the files for the nvcomp dependency (i.e.: cmake config, shared libraries, etc.). This results in downstream projects depending on the libcudf build result to fail to configure due to the missing nvcomp dependency of libcudf, e.g.:
Steps/Code to reproduce bug
Perform a cmake install of libcudf and note the lack of nvcomp artifacts in the install area.
To reproduce the downstream project error noted above:
Reverting #16946 in thirdparty/cudf before the build/build-in-docker command allows the build to succeed.
Expected behavior
nvcomp build artifacts are installed alongside libcudf artifacts for a libcudf install since nvcomp is a required dependency.
The text was updated successfully, but these errors were encountered: