Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Update DEVELOPER_GUIDE.md after conversion to rmm::device_async_resource_ref #15561

Closed
harrism opened this issue Apr 17, 2024 · 0 comments · Fixed by #15562
Closed

[DOC] Update DEVELOPER_GUIDE.md after conversion to rmm::device_async_resource_ref #15561

harrism opened this issue Apr 17, 2024 · 0 comments · Fixed by #15562
Labels
doc Documentation libcudf Affects libcudf (C++/CUDA) code.

Comments

@harrism
Copy link
Member

harrism commented Apr 17, 2024

Report incorrect documentation

Location of incorrect documentation
DEVELOPER_GUIDE.md (libcudf)

Describe the problems or issues found in the documentation
After #15507 merged, the guidance on memory resource parameters in developer guide is incorrect.

Steps taken to verify documentation is incorrect
List any steps you have taken:

Suggested fix for documentation
Replace MR pointer guidance with resource_ref guidance.
@harrism harrism added doc Documentation libcudf Affects libcudf (C++/CUDA) code. labels Apr 17, 2024
@harrism harrism mentioned this issue Apr 17, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Apr 29, 2024
@harrism
Update developer guide with device_async_resource_ref guidelines (#15562
ab5e3f3 
)

Closes #15561

Updates guidance in libcudf DEVELOPER_GUIDE.md to cover resource refs and change examples to not use `device_memory_resource` pointers.

Authors:
  - Mark Harris (https://github.com/harrism)
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - Paul Mattione (https://github.com/pmattione-nvidia)
  - Nghia Truong (https://github.com/ttnghia)

URL: #15562
@github-project-automation github-project-automation bot moved this from Todo to Done in RMM Project Board Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Documentation libcudf Affects libcudf (C++/CUDA) code.
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update developer guide with device_async_resource_ref guidelines harrism/cudf
1 participant
@harrism