You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is it possible to make it consistent with pandas' date_range() in that the result includes both ends? Because, closed parameter is nonfunctional at the moment, to make cudf.date_range() produce the same output as its pandas counterpart, we need to add 1 freq to end, which creates a whole lot of work: convert the string to datetime, convert freq to timedelta and add them to define a new end.
Anyway, is it possible to make it clear in the documentation that this is different from its pandas counterpart?
I didn't know how to tag this since it's not really a bug. It's just different from pandas API that results in a subtle bug in my code.
The text was updated successfully, but these errors were encountered:
Precursor to #15116
* Aligns `date_range` signature with pandas, _technically_ an API breakage with `closed` changing defaults even though it still isn't supported
* Copies pandas behavior of allowing `date_range` with just two of `start/end/periods`
* Supports `tz` arg now
Authors:
- Matthew Roeschke (https://github.com/mroeschke)
Approvers:
- GALI PREM SAGAR (https://github.com/galipremsagar)
URL: #15139
If I create a DatetimeIndex object using
cudf.date_range()
by passingstart
,end
andfreq
parameters:As you can see, the result is an object with length 4. The same code in pandas results in an object with length 5:
Is it possible to make it consistent with pandas'
date_range()
in that the result includes both ends? Because,closed
parameter is nonfunctional at the moment, to makecudf.date_range()
produce the same output as its pandas counterpart, we need to add 1freq
toend
, which creates a whole lot of work: convert the string to datetime, convert freq to timedelta and add them to define a new end.Anyway, is it possible to make it clear in the documentation that this is different from its pandas counterpart?
I didn't know how to tag this since it's not really a bug. It's just different from pandas API that results in a subtle bug in my code.
The text was updated successfully, but these errors were encountered: