Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Implement cudf::stable_sort #15065

Closed
wence- opened this issue Feb 15, 2024 · 0 comments · Fixed by #15066
Closed

[FEA] Implement cudf::stable_sort #15065

wence- opened this issue Feb 15, 2024 · 0 comments · Fixed by #15066
Assignees
@wence-
Labels
3 - Ready for Review Ready for review by team feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@wence-
Copy link
Contributor

wence- commented Feb 15, 2024

Is your feature request related to a problem? Please describe.

libcudf implements stable versions of sorted_order, sort_by_key, segmented_sorted_order, and segmented_sort_by_key.

However, it does not do so for sort itself.

Describe the solution you'd like

An implementation of stable_sort, everything is in place, it just needs to be plumbed in, I think.
@wence- wence- added the feature request New feature or request label Feb 15, 2024
@wence- wence- self-assigned this Feb 15, 2024
@wence- wence- added libcudf Affects libcudf (C++/CUDA) code. helps: Python 1 - On Deck To be worked on next labels Feb 15, 2024
wence- added a commit to wence-/cudf that referenced this issue Feb 15, 2024
@wence-
Implement cudf::stable_sort
45605ba 
- Closes rapidsai#15065
@wence- wence- mentioned this issue Feb 15, 2024
Merged
3 tasks
wence- added a commit to wence-/cudf that referenced this issue Feb 26, 2024
@wence-
Implement cudf::stable_sort
1444488 
- Closes rapidsai#15065
copy-pr-bot bot pushed a commit that referenced this issue Feb 26, 2024
@wence-
Implement cudf::stable_sort
033158d 
- Closes #15065
wence- added a commit to wence-/cudf that referenced this issue Feb 27, 2024
@wence-
Implement cudf::stable_sort
97e1183 
- Closes rapidsai#15065
@wence- wence- added 3 - Ready for Review Ready for review by team and removed 1 - On Deck To be worked on next labels Feb 27, 2024
rapids-bot bot pushed a commit that referenced this issue Feb 29, 2024
@wence-
Implement stable version of cudf::sort (#15066)
50630b2 
Adds an implementation of `cudf::stable_sort`. While here, cleans up a few small issues around stream-passing and memory resource usage in the detail APIs of some of the sort functions.

- Closes #15065

Authors:
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Yunsong Wang (https://github.com/PointKernel)

URL: #15066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wence- wence-

Labels
3 - Ready for Review Ready for review by team feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement stable version of cudf::sort wence-/cudf
2 participants
@wence- @vyasr