Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete restrictions of __CUDA_ARCH__ >= 700. #15030

Closed
harrism opened this issue Feb 12, 2024 · 0 comments · Fixed by #15218
Closed

Remove obsolete restrictions of __CUDA_ARCH__ >= 700. #15030

harrism opened this issue Feb 12, 2024 · 0 comments · Fixed by #15218
Labels
feature request New feature or request

Comments

@harrism
Copy link
Member

harrism commented Feb 12, 2024

cudf now requires Volta+, so we can remove #if __CUDA_ARCH__ >= 700 everywhere.

Originally posted by @bdice in #14993 (comment)
@harrism harrism added this to libcudf Feb 12, 2024
@harrism harrism added feature request New feature or request tech debt labels Feb 12, 2024
@harrism harrism mentioned this issue Feb 12, 2024
Closed
3 tasks
@vyasr vyasr removed the tech debt label Feb 23, 2024
@bdice bdice mentioned this issue Mar 4, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Mar 5, 2024
@bdice
Clean up usage of __CUDA_ARCH__ and other macros. (#15218)
b60bf18 
Closes #15030.

This PR cleans up references to `__CUDA_ARCH__` and other macros.

- We can safely drop Pascal support now that the required minimum is Volta (`__CUDA_ARCH__` of 700).
- Removed a leftover reference to CUDA 10.
- Removed an instance of `#if 1` that was no longer needed.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Michael Schellenberger Costa (https://github.com/miscco)
  - Nghia Truong (https://github.com/ttnghia)
  - Mike Wilson (https://github.com/hyperbolic2346)

URL: #15218
@GregoryKimball GregoryKimball removed this from libcudf Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up usage of __CUDA_ARCH__ and other macros. bdice/cudf
2 participants
@harrism @vyasr