Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Pin wheel builds to numpy <1.25 #14155

Closed
wence- opened this issue Sep 21, 2023 · 1 comment · Fixed by #14156
Closed

[BUG] Pin wheel builds to numpy <1.25 #14155

wence- opened this issue Sep 21, 2023 · 1 comment · Fixed by #14156
Assignees
@bdice
Labels
bug Something isn't working

Comments

@wence-
Copy link
Contributor

wence- commented Sep 21, 2023 •
edited
Loading

Describe the bug

Numpy 1.26 is out, and produces deprecation warnings in pandas (1.5.x). We notice this in wheel builds which don't have an upper bound pin (e.g. https://github.com/rapidsai/cudf/actions/runs/6262541728/job/17005833818?pr=14142)

Expected behavior

Pin to appropriate version
@wence- wence- added bug Something isn't working python labels Sep 21, 2023
@bdice bdice mentioned this issue Sep 21, 2023
Merged
3 tasks
@bdice
Copy link
Contributor

bdice commented Sep 21, 2023

The reason we're seeing this warning now is not due to numpy 1.26 (which came out last week). It's because numba 0.58 came out 6 hours ago. The previous release of 0.57.1 was transitively bounding our numpy to <1.25. That restriction is lifted in numba 0.58 (numba/numba#9011) so now cudf was able to fetch numpy 1.25 which raises these deprecations. The proper solution is still to bound to numpy <1.25.

rapids-bot bot pushed a commit that referenced this issue Sep 21, 2023
@bdice
Pin to numpy<1.25 and numba<0.58 to avoid errors and deprecation warn…
f0ba859 
…ings-as-errors. (#14156)

Closes #14155.

Related: #14160.

(Will newer numpy support be backported to pandas 1.x? edit: no, see below)

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Benjamin Zaitlen (https://github.com/quasiben)
  - Ray Douglass (https://github.com/raydouglass)
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: #14156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdice bdice

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin to numpy<1.25 and numba<0.58 to avoid errors and deprecation warnings-as-errors. bdice/cudf
2 participants
@wence- @bdice