Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Rolling window function tests fail assert in DEBUG #13855

Closed
mythrocks opened this issue Aug 11, 2023 · 1 comment · Fixed by #14168
Closed

[BUG] Rolling window function tests fail assert in DEBUG #13855

mythrocks opened this issue Aug 11, 2023 · 1 comment · Fixed by #14168
Assignees
@mythrocks
Labels
bug Something isn't working

Comments

@mythrocks
Copy link
Contributor

ROLLING_TEST seems to be failing asserts in DEBUG builds, even though the results are correct.

gtests/ROLLING_TEST --gtest_filter=TypedCollectListTest/0.BasicGroupedTimeRangeRollingWindow

Fails this assert in grouped_rolling.cu.

    cudf_assert(type_id_matches_device_storage_typeT(col.type().id()) &&
                "the data type mismatch");

The instantiation type T=int32_t does not match the col.type().id() == TIMESTAMP_DAYS.
@mythrocks mythrocks added the bug Something isn't working label Aug 11, 2023
@mythrocks mythrocks self-assigned this Aug 11, 2023
@mythrocks
Copy link
Contributor Author

(Hat-tip to @davidwendt for the report.)

@davidwendt davidwendt changed the title [BUG] Window function tests fail assert in DEBUG [BUG] Rolling window function tests fail assert in DEBUG Aug 11, 2023
mythrocks added a commit to mythrocks/cudf that referenced this issue Sep 22, 2023
@mythrocks
Fix assert failure for range window functions
97a4022 
Fixes rapidsai#13855.

This commit fixes an erroneous assert check in range window functions,
where the wrong data-type is checked for timestamp order-by columns.

For timestamps, it's the duration::rep type that should be checked,
when accessing the order by column.

This fix allows ROLLING_TEST to complete correctly, in DEBUG mode.
@mythrocks mythrocks mentioned this issue Sep 22, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mythrocks mythrocks

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix assert failure for range window functions mythrocks/cudf
1 participant
@mythrocks