Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Refactor transform_lists_of_structs in row_operators.cu #13287

Closed
ttnghia opened this issue May 4, 2023 · 0 comments · Fixed by #13288
Closed

[FEA] Refactor transform_lists_of_structs in row_operators.cu #13287

ttnghia opened this issue May 4, 2023 · 0 comments · Fixed by #13288
Assignees
Labels
feature request New feature or request

Comments

@ttnghia
Copy link
Contributor

ttnghia commented May 4, 2023

As discussed in https://github.com/rapidsai/cudf/pull/12953/files#r1176816066, the function transform_lists_of_structs in row_operators.cu should be either split into two separate functions or simplified its implementation (by using #12932). Since #12932 is no longer relevant, we are left with just one option which is to split it into two separate functions, each processing one table input vs two tables input.

@ttnghia ttnghia added feature request New feature or request Needs Triage Need team to review and classify and removed Needs Triage Need team to review and classify labels May 4, 2023
@ttnghia ttnghia self-assigned this May 4, 2023
rapids-bot bot pushed a commit that referenced this issue May 15, 2023
This split the functions `transform_lists_of_structs` in `row_operators.cu` into separate functions or simplified their implementation. From one function that can process both cases of having either one or two input columns, now we have two functions, each one processes one case.

Closes #13287.

Authors:
  - Nghia Truong (https://github.com/ttnghia)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Mike Wilson (https://github.com/hyperbolic2346)
  - Bradley Dice (https://github.com/bdice)

URL: #13288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant