-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Crash running parquet reader benchmarks. #13229
Comments
The first benchmark there doesn't appear to be valgrind-clean which may give a hint:
|
I found that when setting the io type to Filepath, it is the source of the segfaults and cudaContext errors. I was wondering if the issue had some relation to kvikio, as this is the error I am seeing when running valgrind. I was also wondering if there is any way to disable using kvikio to see if that is the source of the issue?
|
Thank you @sdrp713 for looking into this segfault and sharing some valgrind results. You might try setting |
Or try However, I think the valgrind outputs looks like innocent memory leaks at exit? Not something to trigger segfaults? |
Ok, I tried setting |
I am not able to reproduce :/
Can you try running until it segfaults with |
rapidsai#16787) The NVbench application `PARQUET_READER_NVBENCH` in libcudf currently crashes with the segmentation fault. To reproduce: ``` ./PARQUET_READER_NVBENCH -d 0 -b 1 --run-once -a io_type=FILEPATH -a compression_type=SNAPPY -a cardinality=0 -a run_length=1 ``` The root cause is that some (1) `thread_local` objects on the main thread in `libcudf` and (2) `static` objects in `kvikio` are destroyed after `cudaDeviceReset()` in NVbench and upon program termination. These objects should simply be leaked, since their destructors making CUDA calls upon program termination constitutes UB in CUDA. This simple PR is the cuDF side of the fix. The other part is done here rapidsai/kvikio#462. closes rapidsai#13229 Authors: - Tianyu Liu (https://github.com/kingcrimsontianyu) - Vukasin Milovanovic (https://github.com/vuule) Approvers: - Vukasin Milovanovic (https://github.com/vuule) - Nghia Truong (https://github.com/ttnghia) URL: rapidsai#16787
The PARQUET_READER_NVBENCH crashes (segfault) at exit on some machines. It doesn't seem to happen consistently for everyone, but it tends to be reproducible once it starts happening.
To reproduce, run PARQUET_READER_NVBENCH and you should get a segfault right at the end after it has printed out all of it's results.
I've narrowed it down to something specific to the
parquet_read_io_compression
suite. In addition,compute-sanitizer
does not turn anything up so this seems to be something purely cpu-side.The text was updated successfully, but these errors were encountered: