Turn on xfail_strict=true in all subpackages
#12391
Assignees
Labels
improvement
Improvement / enhancement to an existing function
Comments
wence-
added
code quality
improvement
3 tasks
rapids-bot bot
pushed a commit
that referenced
this issue
Oct 8, 2024
The cudf tests already treat tests that are expected to fail but pass as errors, but at the time we introduced that change, we didn't do the same for the other packages. Do that now, it turns out there are only a few xpassing tests. While here, it turns out that having multiple different pytest configuration files does not work. `pytest.ini` takes precedence over other options, and it's "first file wins". Consequently, the merge of #16851 turned off `xfail_strict = true` (and other options) for many of the subpackages. To fix this, migrate all pytest configuration into the appropriate section of the `pyproject.toml` files, so that all tool configuration lives in the same place. We also add a section in the developer guide to document this choice. - Closes #12391 - Closes #16974 Authors: - Lawrence Mitchell (https://github.com/wence-) Approvers: - James Lamb (https://github.com/jameslamb) - Matthew Roeschke (https://github.com/mroeschke) - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #16977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Followup to #12244.
Can we do the same for other packages in the repo? I would expect that dask-cudf / custreamz / cudf-kafka / strings_udf won't have as many problems as cudf.
Originally posted by @bdice in #12244 (comment)
The text was updated successfully, but these errors were encountered: