-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Calling partition()
on an empty Table leads to a crash
#11700
Comments
firestarman
added
bug
Something isn't working
Needs Triage
Need team to review and classify
labels
Sep 14, 2022
firestarman
changed the title
[BUG] [Java] Calling
[BUG] [JNI] Calling Sep 14, 2022
partition()
on an empty Table leads to a crashpartition()
on an empty Table leads to a crash
The crash happened at line #2644 . When row number is 0 (aka an empty table), the size of |
3 tasks
firestarman
added
libcudf
Affects libcudf (C++/CUDA) code.
and removed
Java
Affects Java cuDF API.
labels
Sep 14, 2022
firestarman
changed the title
[BUG] [JNI] Calling
[BUG] Calling Sep 14, 2022
partition()
on an empty Table leads to a crashpartition()
on an empty Table leads to a crash
rapids-bot bot
pushed a commit
that referenced
this issue
Sep 27, 2022
…ut table (#11709) By definition, the `cudf::partition*` API will return a vector of offsets with size is at least the number of partitions. As such, an output empty table should associate with an output offset array like `[0, 0, ..., 0]` (all zeros). However, currently the output offsets in such situations is an empty array. This PR corrects the implementation for such corner cases. Closes #11700. Authors: - Nghia Truong (https://github.com/ttnghia) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Vukasin Milovanovic (https://github.com/vuule) - Mike Wilson (https://github.com/hyperbolic2346) URL: #11709
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test to reproduce this bug.
After building the libcudf, run the test as the follows
Crash stack
[UPDATES]
The crash happened at line #2644 . When row number is 0 (aka an empty table), the size of
partition_offsets
is 0, thenpartition_offsets.end() - 1
points to an invalid address. But according to thepartition
's doc, the size ofpartition_offsets
should benum_partitions + 1
.The text was updated successfully, but these errors were encountered: