Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support for std::byte in column_device_view's data function #11362

Closed
hyperbolic2346 opened this issue Jul 26, 2022 · 0 comments · Fixed by #11424
Closed

[FEA] Support for std::byte in column_device_view's data function #11362

hyperbolic2346 opened this issue Jul 26, 2022 · 0 comments · Fixed by #11424
Labels
feature request New feature or request

Comments

@hyperbolic2346
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It was noted in the review of byte_array_view here that the use of std::byte would be useful. This wasn't able to be done due to the use of column_device_view's data function, which is uses SFINAE to limit access to is_rep_layout_compatible<T>, which doesn't include std::byte.

Describe the solution you'd like
It would be useful to ask a column_device_view for a std::byte pointer, so adding it as an option in the SFINAE would be useful.

Describe alternatives you've considered
Currently we are using uint8_t for the pointer type.
@hyperbolic2346 hyperbolic2346 added feature request New feature or request Needs Triage Need team to review and classify labels Jul 26, 2022
@hyperbolic2346 hyperbolic2346 mentioned this issue Jul 26, 2022
Merged
3 tasks
@hyperbolic2346 hyperbolic2346 mentioned this issue Aug 2, 2022
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Aug 3, 2022
@hyperbolic2346
Convert byte_array_view to use std::byte (#11424)
554fb10 
When reviewing PR #11322 it was noted that it would be preferable to use `std::byte` for the data type, but at the time that didn't work out, so the plan was to address it later and issue #11362 was created to track it.

Fixes #11362

Authors:
  - Mike Wilson (https://github.com/hyperbolic2346)

Approvers:
  - Tobias Ribizel (https://github.com/upsj)
  - Bradley Dice (https://github.com/bdice)
  - Nghia Truong (https://github.com/ttnghia)

URL: #11424
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert byte_array_view to use std::byte hyperbolic2346/cudf
2 participants
@hyperbolic2346 @bdice