Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] performance regression after semi_anti_join refactor #11299

Closed
abellina opened this issue Jul 19, 2022 · 1 comment · Fixed by #11330
Closed

[BUG] performance regression after semi_anti_join refactor #11299

abellina opened this issue Jul 19, 2022 · 1 comment · Fixed by #11330
Assignees
@ttnghia
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.

Comments

@abellina
Copy link
Contributor

abellina commented Jul 19, 2022 •
edited
Loading

We are seeing an issue in NDS query14_part1 where we see it seemingly never finishes with cuDF versions after: #11100. Reverting this PR fixes the issue. I believe it's making slow progress, but other timeouts are kicking in (in one case after 2 hours). I can see the issue is the left_semi_join cuDF call, specifically cuco::detail::insert taking all of the time.

In scala, a pretty easy repro is:

import ai.rapids.cudf.Table
val left = Table.readParquet(new java.io.File("left_keys_1bacb1e0-70cb-4cba-b01d-b49bd09842e2544880846.parquet"))
val right = Table.readParquet(new java.io.File("right_keys_1bacb1e0-70cb-4cba-b01d-b49bd09842e21899732691.parquet"))
spark.time { left.leftSemiJoinGatherMap(right, false) }

This is 3 seconds with the new code, and a few millis (I've seen as low as 3 ms) after reverting the PR.

regerssion_cudf_samples.zip
@abellina abellina added bug Something isn't working Needs Triage Need team to review and classify labels Jul 19, 2022
@bdice bdice added libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Jul 20, 2022
@PointKernel PointKernel mentioned this issue Jul 20, 2022
Closed
This was referenced Jul 20, 2022
Closed
Closed
Closed
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 22, 2022
@ttnghia
Fix performance issue and add a new code path to `cudf::detail::conta…
204218a 
…ins` (#11330)

The current implementation of `cudf::detail::contains` can process input with arbitrary nested types. However, it was reported to have severe performance issue when the input tables have many duplicate rows (#11299). In order to fix the issue, #11310 and #11325 was created. 

Unfortunately, #11310 is separating semi-anti-join from `cudf::detail::contains`, causing duplicate implementation. On the other hand, #11325 can address the issue #11299 but semi-anti-join using it still performs worse than the previous semi-anti-join implementation.

The changes in this PR include the following:
 * Fix the performance issue reported in #11299 for the current `cudf::detail::contains` implementation that support nested types.
 * Add a separate code path into `cudf::detail::contains` such that:
     * Input without having lists column (at any nested level) will be processed by the code path that is the same as the old implementation of semi-anti-join. This is to make sure the performance of semi-anti-join will remain the same as before.
     * Input with nested lists column, or NaNs compared as unequal, will be processed by another code path that supports nested types and different NaNs behavior. This will make sure support for nested types will not be dropped.

Closes #11299.

Authors:
  - Nghia Truong (https://github.com/ttnghia)

Approvers:
  - Yunsong Wang (https://github.com/PointKernel)
  - Bradley Dice (https://github.com/bdice)
  - MithunR (https://github.com/mythrocks)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Mike Wilson (https://github.com/hyperbolic2346)
  - Alessandro Bellina (https://github.com/abellina)

URL: #11330
@divyegala
Copy link
Member

@abellina could you please help in testing this PR to check if any regression still exists in the query you were running before? We are trying to unify code paths but this time with hopefully no regressions #13119

@vyasr vyasr mentioned this issue Apr 24, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttnghia ttnghia

Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
4 participants
@abellina @bdice @ttnghia @divyegala