Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Index.isna should return an array, not an Index #11159

Closed
vyasr opened this issue Jun 28, 2022 · 2 comments · Fixed by #11769
Closed

[BUG] Index.isna should return an array, not an Index #11159

vyasr opened this issue Jun 28, 2022 · 2 comments · Fixed by #11769
Assignees
@galipremsagar
Labels
bug Something isn't working Python Affects Python cuDF API.

Comments

@vyasr
Copy link
Contributor

vyasr commented Jun 28, 2022

Describe the bug
Currently, calling isna (or isnull) on any index type will return an Int64Index of dtype bool. It should instead return a cupy array to match pandas behavior (returning a numpy array).

Steps/Code to reproduce bug

>>> cudf.Index([1, 2, 3, 4, 5]).isna()
Int64Index([False, False, False, False, False], dtype='bool')

Expected behavior

>>> cudf.Index([1, 2, 3, 4, 5]).isna()
array([False, False, False, False, False])
@vyasr vyasr added bug Something isn't working Needs Triage Need team to review and classify labels Jun 28, 2022
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@galipremsagar galipremsagar self-assigned this Aug 4, 2022
@galipremsagar galipremsagar added Python Affects Python cuDF API. and removed Needs Triage Need team to review and classify inactive-30d labels Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Sep 3, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@galipremsagar galipremsagar mentioned this issue Sep 26, 2022
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Sep 26, 2022
@galipremsagar
Fix return type of Index.isna & Index.notna (#11769)
e64c2da 
This PR fixes: #11159 by returning correct object type for the result of `isna` & `notna` in `Index`.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Charles Blackmon-Luca (https://github.com/charlesbluca)

URL: #11769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galipremsagar galipremsagar

Labels
bug Something isn't working Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix return type of Index.isna & Index.notna galipremsagar/cudf
2 participants
@vyasr @galipremsagar