You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The use of an mr parameter in inplace_bitmask_and, which calls inplace_bitmask_binop, is a little misleading. The allocations there are always temporary and are not part of the return value. It is only used for a few temporary arrays/scalars:
It should be possible to refactor the inplace functions to remove mr as an argument, and instead use the default memory resource. This avoids the implication that the passed mr is used for the returned data (it is not, since it acts in-place on bitmasks passed in that were from some other allocator).
The use of an
mr
parameter ininplace_bitmask_and
, which callsinplace_bitmask_binop
, is a little misleading. The allocations there are always temporary and are not part of the return value. It is only used for a few temporary arrays/scalars:cudf/cpp/include/cudf/detail/null_mask.cuh
Lines 169 to 171 in 1f8a03e
It should be possible to refactor the
inplace
functions to removemr
as an argument, and instead use the default memory resource. This avoids the implication that the passedmr
is used for the returned data (it is not, since it acts in-place on bitmasks passed in that were from some other allocator).Originally posted by @bdice in #10447 (comment)
The text was updated successfully, but these errors were encountered: