Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] When using libcudf replace_re with ? and *, some combinations of inputs trigger cudaErrorIllegalAddress #10753

Closed
NVnavkumar opened this issue Apr 28, 2022 · 3 comments · Fixed by #10760
Closed

[BUG] When using libcudf replace_re with ? and *, some combinations of inputs trigger cudaErrorIllegalAddress #10753

NVnavkumar opened this issue Apr 28, 2022 · 3 comments · Fixed by #10760
Assignees
@davidwendt
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python)

Comments

@NVnavkumar
Copy link
Contributor

NVnavkumar commented Apr 28, 2022 •
edited by davidwendt
Loading

Describe the bug
A cudaErrorIllegalAddress error is triggered when using regular expressions and replace with some combinations of inputs and outputs with * and ?. This error is a permanent state for the process (probably memory corruption), and cuDF becomes unusable unless the process is restarted.

Steps/Code to reproduce bug
Python code examples:

One with *.

import cudf

s = cudf.Series(["DD"])
s.str.replace("D*", "_REPLACE", regex=True) # triggers cudaErrorIllegalAddress

# Future uses of cudf will trigger cudaErrorIllegalAddress
s = cudf.Series(["abcd"]) # trigers cudaErrorIllegalAddress

And here is one with ?

import cudf

s = cudf.Series["DsDs"])
s.str.replace("D?s?", "_REPLACE_", regex=True) # triggers cudaErrorIllegalAddress

s = cudf.Series(["abcd"]) # trigers cudaErrorIllegalAddress

Expected behavior
At minimum, the crash should not impact future calls to cuDF (causing future GPU calls to be unusable) but these regular expressions should function in cuDF

Environment overview (please complete the following information)

  • Environment location: Bare-metal
  • Method of cuDF install: from source

Environment details

Click here to see environment details 
 **git***
 commit 9ac24773d186c22ffbacbe31d92dad60ed2cdb5f (HEAD -> branch-22.06, upstream/branch-22.06, origin/branch-22.06)
 Author: Karthikeyan <[email protected]>
 Date:   Thu Apr 28 21:52:46 2022 +0530
 
 Implement all methods of groupby rank aggregation in libcudf, python (#9569)
 
 Addresses part of https://github.com/rapidsai/cudf/issues/3591
 
 - [x] move RANK (min method), DENSE_RANK (dense method) into single RANK aggregation
 - [x] max method
 - [x] average method
 - [x] first method
 - [x] percentage
 - [x] order, null order
 RANK, DENSE_RANK was implemented for spark requirement. Pandas groupby has 3 more methods. `rank(column_view, rank_method)` already has all 5 methods implemented.
 
 Current implementation has 2 separate aggregations RANK and DENSE_RANK. This is merged to single RANK with parameters `rank_aggregation(rank_method method, null_policy null_handling, bool percentage)`
 Groupby.rank support for 3 more methods will be added.
 
 This PR is also pre-requisite for spearman correlation.
 
 
 Additionally
 - [x] Cython, Python plumbing
 - [x] benchmark for groupby rank (all methods)
 - [x] PERCENT_RANK aggregation is replaced with MIN_0_INDEXED rank_method in RANK aggregation
 
 Authors:
 - Karthikeyan (https://github.com/karthikeyann)
 
 Approvers:
 - Vyas Ramasubramani (https://github.com/vyasr)
 - MithunR (https://github.com/mythrocks)
 - Jake Hemstad (https://github.com/jrhemstad)
 
 URL: https://github.com/rapidsai/cudf/pull/9569
 **git submodules***
 
 ***OS Information***
 DISTRIB_ID=Ubuntu
 DISTRIB_RELEASE=20.04
 DISTRIB_CODENAME=focal
 DISTRIB_DESCRIPTION="Ubuntu 20.04.4 LTS"
 NAME="Ubuntu"
 VERSION="20.04.4 LTS (Focal Fossa)"
 ID=ubuntu
 ID_LIKE=debian
 PRETTY_NAME="Ubuntu 20.04.4 LTS"
 VERSION_ID="20.04"
 HOME_URL="https://www.ubuntu.com/"
 SUPPORT_URL="https://help.ubuntu.com/"
 BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
 PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
 VERSION_CODENAME=focal
 UBUNTU_CODENAME=focal
 Linux navink-dt 5.14.0-1033-oem #36-Ubuntu SMP Mon Apr 4 15:15:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
 
 ***GPU Information***
 Thu Apr 28 13:10:10 2022
 +-----------------------------------------------------------------------------+
 | NVIDIA-SMI 510.60.02    Driver Version: 510.60.02    CUDA Version: 11.6     |
 |-------------------------------+----------------------+----------------------+
 | GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
 | Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
 |                               |                      |               MIG M. |
 |===============================+======================+======================|
 |   0  NVIDIA RTX A5000    Off  | 00000000:61:00.0 Off |                  Off |
 | 30%   43C    P2    61W / 230W |    676MiB / 24564MiB |      0%      Default |
 |                               |                      |                  N/A |
 +-------------------------------+----------------------+----------------------+
 
 +-----------------------------------------------------------------------------+
 | Processes:                                                                  |
 |  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
 |        ID   ID                                                   Usage      |
 |=============================================================================|
 |    0   N/A  N/A      2128      G   /usr/lib/xorg/Xorg                128MiB |
 |    0   N/A  N/A      2353      G   /usr/bin/gnome-shell                8MiB |
 |    0   N/A  N/A   1000984      C   .../envs/cudf_dev/bin/python      535MiB |
 +-----------------------------------------------------------------------------+
 
 ***CPU***
 Architecture:                    x86_64
 CPU op-mode(s):                  32-bit, 64-bit
 Byte Order:                      Little Endian
 Address sizes:                   43 bits physical, 48 bits virtual
 CPU(s):                          64
 On-line CPU(s) list:             0-63
 Thread(s) per core:              2
 Core(s) per socket:              32
 Socket(s):                       1
 NUMA node(s):                    1
 Vendor ID:                       AuthenticAMD
 CPU family:                      23
 Model:                           49
 Model name:                      AMD Ryzen Threadripper PRO 3975WX 32-Cores
 Stepping:                        0
 Frequency boost:                 enabled
 CPU MHz:                         2200.000
 CPU max MHz:                     4368.1641
 CPU min MHz:                     2200.0000
 BogoMIPS:                        6986.58
 Virtualization:                  AMD-V
 L1d cache:                       1 MiB
 L1i cache:                       1 MiB
 L2 cache:                        16 MiB
 L3 cache:                        128 MiB
 NUMA node0 CPU(s):               0-63
 Vulnerability Itlb multihit:     Not affected
 Vulnerability L1tf:              Not affected
 Vulnerability Mds:               Not affected
 Vulnerability Meltdown:          Not affected
 Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
 Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
 Vulnerability Spectre v2:        Mitigation; Retpolines, IBPB conditional, STIBP conditional, RSB filling
 Vulnerability Srbds:             Not affected
 Vulnerability Tsx async abort:   Not affected
 Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 hw_pstate ssbd mba ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 cqm rdt_a rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local clzero irperf xsaveerptr rdpru wbnoinvd arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif v_spec_ctrl umip rdpid overflow_recov succor smca sme sev sev_es
 
 ***CMake***
 /home/navink/miniconda3/envs/cudf_dev/bin/cmake
 cmake version 3.22.3
 
 CMake suite maintained and supported by Kitware (kitware.com/cmake).
 
 ***g++***
 /usr/bin/g++
 g++ (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
 Copyright (C) 2019 Free Software Foundation, Inc.
 This is free software; see the source for copying conditions.  There is NO
 warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 
 
 ***nvcc***
 
 ***Python***
 /home/navink/miniconda3/envs/cudf_dev/bin/python
 Python 3.8.12
 
 ***Environment Variables***
 PATH                            : /home/navink/miniconda3/envs/cudf_dev/bin:/home/navink/miniconda3/condabin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
 LD_LIBRARY_PATH                 :
 NUMBAPRO_NVVM                   :
 NUMBAPRO_LIBDEVICE              :
 CONDA_PREFIX                    : /home/navink/miniconda3/envs/cudf_dev
 PYTHON_PATH                     :
 
 ***conda packages***
 /home/navink/miniconda3/condabin/conda
 # packages in environment at /home/navink/miniconda3/envs/cudf_dev:
 #
 # Name                    Version                   Build  Channel
 _libgcc_mutex             0.1                 conda_forge    conda-forge
 _openmp_mutex             4.5                      1_llvm    conda-forge
 abseil-cpp                20211102.0           h27087fc_1    conda-forge
 alabaster                 0.7.12                     py_0    conda-forge
 appdirs                   1.4.4              pyh9f0ad1d_0    conda-forge
 argon2-cffi               21.3.0             pyhd8ed1ab_0    conda-forge
 argon2-cffi-bindings      21.2.0           py38h497a2fe_1    conda-forge
 arrow-cpp                 6.0.1           py38h0002f4e_11_cuda    conda-forge
 arrow-cpp-proc            3.0.0                      cuda    conda-forge
 asttokens                 2.0.5              pyhd8ed1ab_0    conda-forge
 attrs                     21.4.0             pyhd8ed1ab_0    conda-forge
 aws-c-cal                 0.5.11               h95a6274_0    conda-forge
 aws-c-common              0.6.2                h7f98852_0    conda-forge
 aws-c-event-stream        0.2.7               h3541f99_13    conda-forge
 aws-c-io                  0.10.5               hfb6a706_0    conda-forge
 aws-checksums             0.1.11               ha31a3da_7    conda-forge
 aws-sdk-cpp               1.8.186              hb4091e7_3    conda-forge
 babel                     2.9.1              pyh44b312d_0    conda-forge
 backcall                  0.2.0              pyh9f0ad1d_0    conda-forge
 backports                 1.0                        py_2    conda-forge
 backports-zoneinfo        0.2.1                    pypi_0    pypi
 backports.functools_lru_cache 1.6.4              pyhd8ed1ab_0    conda-forge
 beautifulsoup4            4.10.0             pyha770c72_0    conda-forge
 binutils_impl_linux-64    2.36.1               h193b22a_2    conda-forge
 black                     19.10b0                    py_4    conda-forge
 bleach                    4.1.0              pyhd8ed1ab_0    conda-forge
 bokeh                     2.4.2            py38h578d9bd_0    conda-forge
 brotlipy                  0.7.0           py38h497a2fe_1003    conda-forge
 bzip2                     1.0.8                h7f98852_4    conda-forge
 c-ares                    1.18.1               h7f98852_0    conda-forge
 ca-certificates           2022.3.29            h06a4308_1
 cachetools                5.0.0              pyhd8ed1ab_0    conda-forge
 certifi                   2021.10.8        py38h06a4308_2
 cffi                      1.15.0           py38h3931269_0    conda-forge
 cfgv                      3.3.1              pyhd8ed1ab_0    conda-forge
 charset-normalizer        2.0.12             pyhd8ed1ab_0    conda-forge
 clang                     11.1.0               ha770c72_1    conda-forge
 clang-11                  11.1.0          default_ha53f305_1    conda-forge
 clang-tools               11.1.0          default_ha53f305_1    conda-forge
 clangxx                   11.1.0          default_ha53f305_1    conda-forge
 click                     8.0.4            py38h578d9bd_0    conda-forge
 cloudpickle               2.0.0              pyhd8ed1ab_0    conda-forge
 cmake                     3.22.3               h5432695_0    conda-forge
 cmake_setuptools          0.1.3                      py_0    rapidsai
 colorama                  0.4.4              pyh9f0ad1d_0    conda-forge
 commonmark                0.9.1                      py_0    conda-forge
 cryptography              36.0.2           py38h2b5fc30_0    conda-forge
 cuda-python               11.6.1           py38h3fd9d12_0    nvidia
 cudatoolkit               11.5.1               hcf5317a_9    nvidia
 cudf                      22.4.0a0+469.g9ac24773d1          pypi_0    pypi
 cupy                      10.2.0           py38h405e1b6_0    conda-forge
 cyrus-sasl                2.1.27               h230043b_5    conda-forge
 cython                    0.29.28          py38h709712a_0    conda-forge
 cytoolz                   0.11.2           py38h497a2fe_1    conda-forge
 dask                      2022.3.0           pyhd8ed1ab_0    conda-forge
 dask-core                 2022.3.0           pyhd8ed1ab_0    conda-forge
 dask-cudf                 22.4.0a0+469.g9ac24773d1          pypi_0    pypi
 dataclasses               0.8                pyhc8e2a94_3    conda-forge
 debugpy                   1.5.1            py38h709712a_0    conda-forge
 decorator                 5.1.1              pyhd8ed1ab_0    conda-forge
 defusedxml                0.7.1              pyhd8ed1ab_0    conda-forge
 distlib                   0.3.4              pyhd8ed1ab_0    conda-forge
 distributed               2022.3.0           pyhd8ed1ab_0    conda-forge
 dlpack                    0.5                  h9c3ff4c_0    conda-forge
 docutils                  0.17.1           py38h578d9bd_1    conda-forge
 double-conversion         3.2.0                h9c3ff4c_0    conda-forge
 entrypoints               0.4                pyhd8ed1ab_0    conda-forge
 execnet                   1.9.0              pyhd8ed1ab_0    conda-forge
 executing                 0.8.3              pyhd8ed1ab_0    conda-forge
 expat                     2.4.7                h27087fc_0    conda-forge
 fastavro                  1.4.10           py38h0a891b7_0    conda-forge
 fastrlock                 0.8              py38h709712a_1    conda-forge
 filelock                  3.6.0              pyhd8ed1ab_0    conda-forge
 flake8                    3.8.3                      py_1    conda-forge
 flit-core                 3.7.1              pyhd8ed1ab_0    conda-forge
 freetype                  2.10.4               h0708190_1    conda-forge
 fsspec                    2022.2.0           pyhd8ed1ab_0    conda-forge
 future                    0.18.2           py38h578d9bd_4    conda-forge
 gcc_impl_linux-64         11.2.0              h82a94d6_14    conda-forge
 gettext                   0.19.8.1          h73d1719_1008    conda-forge
 gflags                    2.2.2             he1b5a44_1004    conda-forge
 giflib                    5.2.1                h36c2ea0_2    conda-forge
 glog                      0.5.0                h48cff8f_0    conda-forge
 gmp                       6.2.1                h58526e2_0    conda-forge
 grpc-cpp                  1.44.0               h3d78c48_1    conda-forge
 heapdict                  1.0.1                      py_0    conda-forge
 huggingface_hub           0.4.0              pyhd8ed1ab_0    conda-forge
 hypothesis                6.39.4             pyhd8ed1ab_0    conda-forge
 identify                  2.4.12             pyhd8ed1ab_0    conda-forge
 idna                      3.3                pyhd8ed1ab_0    conda-forge
 imagesize                 1.3.0              pyhd8ed1ab_0    conda-forge
 importlib-metadata        4.11.3           py38h578d9bd_0    conda-forge
 importlib_metadata        4.11.3               hd8ed1ab_0    conda-forge
 importlib_resources       5.4.0              pyhd8ed1ab_0    conda-forge
 iniconfig                 1.1.1              pyh9f0ad1d_0    conda-forge
 ipykernel                 6.9.2            py38h7f3c49e_0    conda-forge
 ipython                   8.1.1            py38h578d9bd_0    conda-forge
 ipython_genutils          0.2.0                      py_1    conda-forge
 isort                     5.6.4                      py_0    conda-forge
 jbig                      2.1               h7f98852_2003    conda-forge
 jedi                      0.18.1           py38h578d9bd_0    conda-forge
 jinja2                    3.1.0              pyhd8ed1ab_0    conda-forge
 joblib                    1.1.0              pyhd8ed1ab_0    conda-forge
 jpeg                      9e                   h7f98852_0    conda-forge
 jsonschema                4.4.0              pyhd8ed1ab_0    conda-forge
 jupyter_client            7.1.2              pyhd8ed1ab_0    conda-forge
 jupyter_core              4.9.2            py38h578d9bd_0    conda-forge
 jupyterlab_pygments       0.1.2              pyh9f0ad1d_0    conda-forge
 kernel-headers_linux-64   2.6.32              he073ed8_15    conda-forge
 keyutils                  1.6.1                h166bdaf_0    conda-forge
 krb5                      1.19.3               h3790be6_0    conda-forge
 lcms2                     2.12                 hddcbb42_0    conda-forge
 ld_impl_linux-64          2.36.1               hea4e1c9_2    conda-forge
 lerc                      3.0                  h9c3ff4c_0    conda-forge
 libblas                   3.9.0            13_linux64_mkl    conda-forge
 libbrotlicommon           1.0.9                h7f98852_6    conda-forge
 libbrotlidec              1.0.9                h7f98852_6    conda-forge
 libbrotlienc              1.0.9                h7f98852_6    conda-forge
 libcblas                  3.9.0            13_linux64_mkl    conda-forge
 libclang-cpp11.1          11.1.0          default_ha53f305_1    conda-forge
 libcurl                   7.82.0               h7bff187_0    conda-forge
 libdeflate                1.10                 h7f98852_0    conda-forge
 libedit                   3.1.20191231         he28a2e2_2    conda-forge
 libev                     4.33                 h516909a_1    conda-forge
 libevent                  2.1.10               h9b69904_4    conda-forge
 libffi                    3.4.2                h7f98852_5    conda-forge
 libgcc-devel_linux-64     11.2.0              h0952999_14    conda-forge
 libgcc-ng                 11.2.0              h1d223b6_14    conda-forge
 libgcrypt                 1.10.0               h7f98852_0    conda-forge
 libgomp                   11.2.0              h1d223b6_14    conda-forge
 libgpg-error              1.44                 h9eb791d_0    conda-forge
 libgsasl                  1.10.0               h5b4c23d_0    conda-forge
 liblapack                 3.9.0            13_linux64_mkl    conda-forge
 libllvm11                 11.1.0               hf817b99_3    conda-forge
 libnghttp2                1.47.0               h727a467_0    conda-forge
 libnsl                    2.0.0                h7f98852_0    conda-forge
 libntlm                   1.4               h7f98852_1002    conda-forge
 libpng                    1.6.37               h21135ba_2    conda-forge
 libprotobuf               3.19.4               h780b84a_0    conda-forge
 librdkafka                1.7.0                hc49e61c_1    conda-forge
 librmm                    22.04.00a220324 cuda11_g220ba88_44    rapidsai-nightly
 libsanitizer              11.2.0              he4da1e4_14    conda-forge
 libsodium                 1.0.18               h36c2ea0_1    conda-forge
 libssh2                   1.10.0               ha56f1ee_2    conda-forge
 libstdcxx-ng              11.2.0              he4da1e4_14    conda-forge
 libthrift                 0.15.0               he6d91bd_1    conda-forge
 libtiff                   4.3.0                h542a066_3    conda-forge
 libutf8proc               2.7.0                h7f98852_0    conda-forge
 libuv                     1.43.0               h7f98852_0    conda-forge
 libwebp                   1.2.2                h3452ae3_0    conda-forge
 libwebp-base              1.2.2                h7f98852_1    conda-forge
 libxcb                    1.13              h7f98852_1004    conda-forge
 libzlib                   1.2.11            h36c2ea0_1013    conda-forge
 llvm-openmp               13.0.1               he0ac6c6_1    conda-forge
 llvmlite                  0.38.0           py38h4630a5e_0    conda-forge
 locket                    0.2.0                      py_2    conda-forge
 lz4-c                     1.9.3                h9c3ff4c_1    conda-forge
 markdown                  3.3.6              pyhd8ed1ab_0    conda-forge
 markupsafe                2.1.1            py38h0a891b7_0    conda-forge
 matplotlib-inline         0.1.3              pyhd8ed1ab_0    conda-forge
 mccabe                    0.6.1                      py_1    conda-forge
 mimesis                   4.0.0              pyh9f0ad1d_0    conda-forge
 mistune                   0.8.4           py38h497a2fe_1005    conda-forge
 mkl                       2022.0.1           h8d4b97c_803    conda-forge
 msgpack-python            1.0.3            py38h1fd1430_0    conda-forge
 mypy                      0.782                      py_0    conda-forge
 mypy_extensions           0.4.3            py38h578d9bd_4    conda-forge
 nbclient                  0.5.13             pyhd8ed1ab_0    conda-forge
 nbconvert                 6.4.4            py38h578d9bd_0    conda-forge
 nbformat                  5.2.0              pyhd8ed1ab_0    conda-forge
 nbsphinx                  0.8.8              pyhd8ed1ab_0    conda-forge
 ncurses                   6.3                  h9c3ff4c_0    conda-forge
 nest-asyncio              1.5.4              pyhd8ed1ab_0    conda-forge
 ninja                     1.10.2               h4bd325d_1    conda-forge
 nodeenv                   1.6.0              pyhd8ed1ab_0    conda-forge
 notebook                  6.4.10             pyha770c72_0    conda-forge
 numba                     0.55.1           py38h4bf6c61_0    conda-forge
 numpy                     1.21.5           py38h87f13fb_0    conda-forge
 numpydoc                  1.2                pyhd8ed1ab_0    conda-forge
 nvtx                      0.2.3            py38h497a2fe_1    conda-forge
 openjpeg                  2.4.0                hb52868f_1    conda-forge
 openssl                   1.1.1n               h7f8727e_0
 orc                       1.7.3                h1be678f_0    conda-forge
 packaging                 21.3               pyhd8ed1ab_0    conda-forge
 pandas                    1.3.5            py38h43a58ef_0    conda-forge
 pandoc                    1.19.2                        0    conda-forge
 pandocfilters             1.5.0              pyhd8ed1ab_0    conda-forge
 parquet-cpp               1.5.1                         2    conda-forge
 parso                     0.8.3              pyhd8ed1ab_0    conda-forge
 partd                     1.2.0              pyhd8ed1ab_0    conda-forge
 pathspec                  0.9.0              pyhd8ed1ab_0    conda-forge
 pexpect                   4.8.0              pyh9f0ad1d_2    conda-forge
 pickleshare               0.7.5                   py_1003    conda-forge
 pillow                    9.0.1            py38h0ee0e06_2    conda-forge
 pip                       22.0.4             pyhd8ed1ab_0    conda-forge
 platformdirs              2.5.1              pyhd8ed1ab_0    conda-forge
 pluggy                    1.0.0            py38h578d9bd_2    conda-forge
 pre-commit                2.17.0           py38h578d9bd_0    conda-forge
 prometheus_client         0.13.1             pyhd8ed1ab_0    conda-forge
 prompt-toolkit            3.0.27             pyha770c72_0    conda-forge
 protobuf                  3.19.4           py38h709712a_0    conda-forge
 psutil                    5.9.0            py38h497a2fe_0    conda-forge
 pthread-stubs             0.4               h36c2ea0_1001    conda-forge
 ptxcompiler               0.2.0            py38h98f4b32_0    rapidsai
 ptyprocess                0.7.0              pyhd3deb0d_0    conda-forge
 pure_eval                 0.2.2              pyhd8ed1ab_0    conda-forge
 py                        1.11.0             pyh6c4a22f_0    conda-forge
 py-cpuinfo                8.0.0              pyhd8ed1ab_0    conda-forge
 pyarrow                   6.0.1           py38ha746e9d_11_cuda    conda-forge
 pycodestyle               2.6.0              pyh9f0ad1d_0    conda-forge
 pycparser                 2.21               pyhd8ed1ab_0    conda-forge
 pydata-sphinx-theme       0.8.0              pyhd8ed1ab_0    conda-forge
 pydocstyle                6.1.1              pyhd8ed1ab_0    conda-forge
 pyflakes                  2.2.0              pyh9f0ad1d_0    conda-forge
 pygments                  2.11.2             pyhd8ed1ab_0    conda-forge
 pyopenssl                 22.0.0             pyhd8ed1ab_0    conda-forge
 pyorc                     0.6.0                    pypi_0    pypi
 pyparsing                 3.0.7              pyhd8ed1ab_0    conda-forge
 pyrsistent                0.18.1           py38h497a2fe_0    conda-forge
 pysocks                   1.7.1            py38h578d9bd_4    conda-forge
 pytest                    7.1.1            py38h578d9bd_0    conda-forge
 pytest-benchmark          3.4.1              pyhd8ed1ab_0    conda-forge
 pytest-forked             1.4.0              pyhd8ed1ab_0    conda-forge
 pytest-xdist              2.5.0              pyhd8ed1ab_0    conda-forge
 python                    3.8.12          ha38a3c6_3_cpython    conda-forge
 python-confluent-kafka    1.7.0            py38h497a2fe_2    conda-forge
 python-dateutil           2.8.2              pyhd8ed1ab_0    conda-forge
 python-snappy             0.6.0            py38h49bdff1_1    conda-forge
 python_abi                3.8                      2_cp38    conda-forge
 pytorch                   1.11.0          cpu_py38hde1b6bc_0    conda-forge
 pytz                      2022.1             pyhd8ed1ab_0    conda-forge
 pyyaml                    6.0              py38h497a2fe_3    conda-forge
 pyzmq                     22.3.0           py38h2035c66_1    conda-forge
 rapidjson                 1.1.0             he1b5a44_1002    conda-forge
 re2                       2022.02.01           h9c3ff4c_0    conda-forge
 readline                  8.1                  h46c0cb4_0    conda-forge
 recommonmark              0.7.1              pyhd8ed1ab_0    conda-forge
 regex                     2022.3.15        py38h0a891b7_0    conda-forge
 requests                  2.27.1             pyhd8ed1ab_0    conda-forge
 rhash                     1.4.1                h7f98852_0    conda-forge
 rmm                       22.04.00a220324 cuda11_py38_g220ba88_44    rapidsai-nightly
 s2n                       1.0.10               h9b69904_0    conda-forge
 sacremoses                0.0.49             pyhd8ed1ab_0    conda-forge
 send2trash                1.8.0              pyhd8ed1ab_0    conda-forge
 setuptools                59.8.0           py38h578d9bd_0    conda-forge
 six                       1.16.0             pyh6c4a22f_0    conda-forge
 sleef                     3.5.1                h9b69904_2    conda-forge
 snappy                    1.1.8                he1b5a44_3    conda-forge
 snowballstemmer           2.2.0              pyhd8ed1ab_0    conda-forge
 sortedcontainers          2.4.0              pyhd8ed1ab_0    conda-forge
 soupsieve                 2.3.1              pyhd8ed1ab_0    conda-forge
 spdlog                    1.8.5                h4bd325d_1    conda-forge
 sphinx                    4.4.0              pyh6c4a22f_1    conda-forge
 sphinx-copybutton         0.5.0              pyhd8ed1ab_0    conda-forge
 sphinx-markdown-tables    0.0.15             pyhd3deb0d_0    conda-forge
 sphinxcontrib-applehelp   1.0.2                      py_0    conda-forge
 sphinxcontrib-devhelp     1.0.2                      py_0    conda-forge
 sphinxcontrib-htmlhelp    2.0.0              pyhd8ed1ab_0    conda-forge
 sphinxcontrib-jsmath      1.0.1                      py_0    conda-forge
 sphinxcontrib-qthelp      1.0.3                      py_0    conda-forge
 sphinxcontrib-serializinghtml 1.1.5              pyhd8ed1ab_1    conda-forge
 sphinxcontrib-websupport  1.2.4              pyhd8ed1ab_1    conda-forge
 sqlite                    3.37.1               h4ff8645_0    conda-forge
 stack_data                0.2.0              pyhd8ed1ab_0    conda-forge
 streamz                   0.6.3              pyh6c4a22f_0    conda-forge
 sysroot_linux-64          2.12                he073ed8_15    conda-forge
 tbb                       2021.5.0             h4bd325d_0    conda-forge
 tblib                     1.7.0              pyhd8ed1ab_0    conda-forge
 terminado                 0.13.3           py38h578d9bd_0    conda-forge
 testpath                  0.6.0              pyhd8ed1ab_0    conda-forge
 tk                        8.6.12               h27826a3_0    conda-forge
 tokenizers                0.10.3           py38hb63a372_1    conda-forge
 toml                      0.10.2             pyhd8ed1ab_0    conda-forge
 tomli                     2.0.1              pyhd8ed1ab_0    conda-forge
 toolz                     0.11.2             pyhd8ed1ab_0    conda-forge
 tornado                   6.1              py38h497a2fe_2    conda-forge
 tqdm                      4.63.1             pyhd8ed1ab_0    conda-forge
 traitlets                 5.1.1              pyhd8ed1ab_0    conda-forge
 transformers              4.10.3             pyhd8ed1ab_0    conda-forge
 typed-ast                 1.4.3            py38h497a2fe_1    conda-forge
 typing-extensions         4.1.1                hd8ed1ab_0    conda-forge
 typing_extensions         4.1.1              pyha770c72_0    conda-forge
 ukkonen                   1.0.1            py38h1fd1430_1    conda-forge
 urllib3                   1.26.9             pyhd8ed1ab_0    conda-forge
 virtualenv                20.13.4          py38h578d9bd_0    conda-forge
 wcwidth                   0.2.5              pyh9f0ad1d_2    conda-forge
 webencodings              0.5.1                      py_1    conda-forge
 wheel                     0.37.1             pyhd8ed1ab_0    conda-forge
 xorg-libxau               1.0.9                h7f98852_0    conda-forge
 xorg-libxdmcp             1.1.3                h7f98852_0    conda-forge
 xz                        5.2.5                h516909a_1    conda-forge
 yaml                      0.2.5                h7f98852_2    conda-forge
 zeromq                    4.3.4                h9c3ff4c_1    conda-forge
 zict                      2.1.0              pyhd8ed1ab_0    conda-forge
 zipp                      3.7.0              pyhd8ed1ab_1    conda-forge
 zlib                      1.2.11            h36c2ea0_1013    conda-forge
 zstd                      1.5.2                ha95c52a_0    conda-forge

@NVnavkumar NVnavkumar added Needs Triage Need team to review and classify bug Something isn't working labels Apr 28, 2022
@NVnavkumar
Copy link
Contributor Author

NVnavkumar commented Apr 28, 2022 •
edited
Loading

Note that this behavior is actually specific to combination of input string and regular expression. For example, if you use a different input string in the example for ? above, the replace call will function properly:

import cudf

s = cudf.Series(["ABCD"])

s.str.replace("D?s?", "_REPLACE_", regex=True) # this will not crash

@davidwendt davidwendt self-assigned this Apr 29, 2022
@davidwendt
Copy link
Contributor

TL;DR: This should not crash and so that will be fixed but the result may be undefined.

So the * and ? are greedy quantifiers but both can apply to the previous character zero times. The ? is zero or one times while the * is zero of more times. The zero is important since it means the expression D* means it can match nothing -- no D or many D. Since it can match nothing, everything matches. Here is a snippet of what Python does with this:

>>> import re
>>> re.sub('D*', '_REPLACED_', 'DD')
'_REPLACED__REPLACED_'

But note this matches anything:

>>> re.sub('D*', '_REPLACED_', 'EE')
'_REPLACED_E_REPLACED_E_REPLACED_'
>>> re.sub('D*', '_REPLACED_', 'what')
'_REPLACED_w_REPLACED_h_REPLACED_a_REPLACED_t_REPLACED_'

If you are trying to use like a wildcard you should use D.* instead

>>> re.sub('D.*', '_REPLACED_', 'DD')
'_REPLACED_'
>>> re.sub('D.*', '_REPLACED_', 'EE')
'EE'

The same issue occurs with D?s? The pattern can match D zero or one and s zero or one and so can match nothing.

>>> re.sub('D?s?', '_REPLACED_', 'ABC')
'_REPLACED_A_REPLACED_B_REPLACED_C_REPLACED_'

Regardless, it should no crash so this is a valid bug. But the I would consider the behavior undefined and would not rely on the output.

@davidwendt davidwendt added libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) labels Apr 29, 2022
@davidwendt davidwendt mentioned this issue Apr 29, 2022
Merged
@NVnavkumar
Copy link
Contributor Author

But note this matches anything:

>>> re.sub('D*', '_REPLACED_', 'EE')
'_REPLACED_E_REPLACED_E_REPLACED_'
>>> re.sub('D*', '_REPLACED_', 'what')
'_REPLACED_w_REPLACED_h_REPLACED_a_REPLACED_t_REPLACED_'

Btw, in cuDF, the behavior seems to be fine in this instance, it is consistent with Python, which is acceptable.

>>> import cudf
>>> s = cudf.Series(["EE"])
>>> s.str.replace("D*", "_REPLACED_", regex=True)
0    _REPLACED_E_REPLACED_E_REPLACED_
dtype: object
>>>
>>> s = cudf.Series("what")
>>> s.str.replace("D*", "_REPLACED_", regex=True)
0    _REPLACED_w_REPLACED_h_REPLACED_a_REPLACED_t_R...
dtype: object

This crash is specific to these combinations of regular expressions and input strings.

If you are trying to use like a wildcard you should use D.* instead

Probably, these are edge cases that came up when I was working on NVIDIA/spark-rapids#4468.

rapids-bot bot pushed a commit that referenced this issue May 3, 2022
@davidwendt
Fix replace error when regex has only zero match quantifiers (#10760)
ad12606 
Closes #10753 

Fixes `cudf::strings::replace_re` logic that was reading past the end of a string when given a regex that contained net zero match quantifier pattern (e.g. 'D*' or 'D?s?' both can match to nothing).

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Bradley Dice (https://github.com/bdice)
  - Mark Harris (https://github.com/harrism)

URL: #10760
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwendt davidwendt

Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix replace error when regex has only zero match quantifiers davidwendt/cudf
3 participants
@bdice @davidwendt @NVnavkumar