Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Enable Decimal128 support in cudf python #10031

Closed
galipremsagar opened this issue Jan 13, 2022 · 0 comments · Fixed by #9533
Closed

[FEA] Enable Decimal128 support in cudf python #10031

galipremsagar opened this issue Jan 13, 2022 · 0 comments · Fixed by #9533
Assignees
@galipremsagar
Labels
feature request New feature or request Python Affects Python cuDF API.

Comments

@galipremsagar
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I'd like cudf python to enable Decimal128 type support and all it's related operation.
@galipremsagar galipremsagar added feature request New feature or request Python Affects Python cuDF API. labels Jan 13, 2022
@galipremsagar galipremsagar self-assigned this Jan 13, 2022
@galipremsagar galipremsagar mentioned this issue Jan 13, 2022
Merged
12 tasks
rapids-bot bot pushed a commit that referenced this issue Jan 18, 2022
@galipremsagar
Add support for decimal128 in cudf python (#9533)
8d7330f 
Resolves: #10031

Depends on #9483, #9986

Note: The CI for this PR is not going to pass until #9986 is admin-merged(Admin merge needed since #9986 requires this PR changes too). 

- [x] Introduced `Decimal128Dtype` and `Decimal128Column`.
- [x] Enabled python side support for the above both.
- [x] Enables complete support for `Decimal32Column` which is currently lacking.
- [x] Enabled orc writer to use decimal128.
- [x] Enabled parquet to read a decimal128 type.
- [x] Enabled Scalar support for `Decimal128Dtype`.
- [x] Covered all decimal types in `string` <-> `decimal` conversions.
- [x] **Made `Decimal128Dtype` the default type while reading in a Decimal Series or Scalar. User can specify to choose a specific decimal type by passing a `dtype`.** (Breaking)
- [x] **Fixed issues in the binop precision & scale calculation logic to correctly choose a decimal type.** (Breaking)
- [x] Fixed type metadata handling issues seen across APIs while making changes.
- [x] Added parametrizations for all missing `decimal32` tests.
- [x] Added parametrizations for `decimal128` along with existing decimal type-specific tests.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Robert (Bobby) Evans (https://github.com/revans2)
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - Devavret Makkar (https://github.com/devavret)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #9533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galipremsagar galipremsagar

Labels
feature request New feature or request Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] Add support for decimal128 in cudf python galipremsagar/cudf
1 participant
@galipremsagar