Skip to content

Commit

Permalink
Revert "Add specific GCC version to clarify the bug"
Browse files Browse the repository at this point in the history
This reverts commit aea7b14.
  • Loading branch information
ttnghia committed Feb 3, 2022
1 parent aea7b14 commit fbae4ea
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cpp/src/binaryop/compiled/util.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ struct common_type_functor {
return data_type{type_to_id<TypeCommon>()};
}

// A GCC-10 compiler bug may cause a compilation error when using empty initializer list to
// construct an std::optional object containing no `data_type` value. Therefore, we should
// explicitly return `std::nullopt` instead.
// A compiler bug may cause a compilation error when using empty initializer list to construct
// an std::optional object containing no `data_type` value. Therefore, we should explicitly
// return `std::nullopt` instead.
return std::nullopt;
}
};
Expand Down

0 comments on commit fbae4ea

Please sign in to comment.