Skip to content

Commit

Permalink
Address initial PR comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
vyasr committed Apr 25, 2022
1 parent 76b27f8 commit f991f97
Showing 1 changed file with 13 additions and 8 deletions.
21 changes: 13 additions & 8 deletions python/cudf/cudf/core/series.py
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ def _constructor_expanddim(self):
@classmethod
@_cudf_nvtx_annotate
def from_categorical(cls, categorical, codes=None):
"""Create from a pandas.Categorical.
"""Create a Series from a pandas.Categorical.
Parameters
----------
Expand Down Expand Up @@ -1597,7 +1597,7 @@ def to_pandas(self, index=True, nullable=False, **kwargs):
@property # type: ignore
@_cudf_nvtx_annotate
def data(self):
"""Get the gpu buffer for the data.
"""Get the GPU buffer for the data.
Returns
-------
Expand All @@ -1624,7 +1624,7 @@ def data(self):
@property # type: ignore
@_cudf_nvtx_annotate
def nullmask(self):
"""Get the gpu buffer for the null-mask."""
"""Get the GPU buffer for the null-mask."""
return cudf.Series(self._column.nullmask)

@_cudf_nvtx_annotate
Expand Down Expand Up @@ -1704,7 +1704,7 @@ def sort_values(

@_cudf_nvtx_annotate
def nlargest(self, n=5, keep="first"):
"""Return a new Series of the *n* largest element.
"""Return a new Series of the *n* largest elements.
Parameters
----------
Expand Down Expand Up @@ -1767,7 +1767,9 @@ def nlargest(self, n=5, keep="first"):

@_cudf_nvtx_annotate
def nsmallest(self, n=5, keep="first"):
"""Return a new Series of the *n* smallest element.
"""Return a new Series of the *n* smallest elements.
Always returns Series even if only one value is returned.
Parameters
----------
Expand Down Expand Up @@ -2267,6 +2269,9 @@ def count(self, level=None, **kwargs):
def mode(self, dropna=True):
"""Return the mode or modes of the dataset.
The mode is the value that appears most often. There can be multiple
modes.
Always returns Series even if only one value is returned.
Parameters
Expand Down Expand Up @@ -2397,7 +2402,7 @@ def transpose(self):

@_cudf_nvtx_annotate
def corr(self, other, method="pearson", min_periods=None):
"""Calculate the sample correlation between two Series.
"""Compute correlation with `other` Series, excluding missing values.
Excludes missing values.
Expand Down Expand Up @@ -3085,7 +3090,7 @@ def groupby(
def rename(self, index=None, copy=True):
"""Alter Series name.
Change Series.name with a scalar value
Change Series.name with a scalar value.
Parameters
----------
Expand Down Expand Up @@ -3896,7 +3901,7 @@ def isocalendar(self):
@property # type: ignore
@_cudf_nvtx_annotate
def is_month_start(self):
"""Booleans indicating if dates are the first day of the month."""
"""Indicate whether the data is the first day of the month."""
return (self.day == 1).fillna(False)

@property # type: ignore
Expand Down

0 comments on commit f991f97

Please sign in to comment.