Remove detail/public split and nvtx range

rapidsai · Jul 11, 2024 · f36e3bc · f36e3bc
1 parent 5bbd380
commit f36e3bc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/cpp/include/cudf/detail/unary.hpp b/cpp/include/cudf/detail/unary.hpp
@@ -86,11 +86,6 @@ std::unique_ptr<column> cast(column_view const& input,
                              rmm::cuda_stream_view stream,
                              rmm::device_async_resource_ref mr);
 
-/**
- * @copydoc cudf::is_supported_cast
- */
-bool is_supported_cast(data_type from, data_type to) noexcept;
-
 /**
  * @copydoc cudf::is_nan
  */

diff --git a/cpp/src/unary/cast_ops.cu b/cpp/src/unary/cast_ops.cu
@@ -468,11 +468,6 @@ struct is_supported_cast_impl {
   }
 };
 
-bool is_supported_cast(data_type from, data_type to) noexcept
-{
-  return double_type_dispatcher(from, to, is_supported_cast_impl{});
-}
-
 }  // namespace detail
 
 std::unique_ptr<column> cast(column_view const& input,
@@ -486,8 +481,9 @@ std::unique_ptr<column> cast(column_view const& input,
 
 bool is_supported_cast(data_type from, data_type to) noexcept
 {
-  CUDF_FUNC_RANGE();
-  return detail::is_supported_cast(from, to);
+  // No matching detail API call/nvtx annotation, since this doesn't
+  // launch a kernel.
+  return double_type_dispatcher(from, to, detail::is_supported_cast_impl{});
 }
 
 }  // namespace cudf