Apply suggestions from code review

Co-authored-by: Keith Kraus <[email protected]>
rapidsai · Mar 1, 2021 · f203cb2 · f203cb2
1 parent 098e4a7
commit f203cb2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/python/cudf/cudf/tests/test_dataframe.py b/python/cudf/cudf/tests/test_dataframe.py
@@ -1214,7 +1214,7 @@ def test_dataframe_concat_different_numerical_columns(dtype1, dtype2):
 
 
 def test_dataframe_concat_different_column_types():
-    df1 = cudf.Series([42], dtype=float)
+    df1 = cudf.Series([42], dtype=np.float64)
     df2 = cudf.Series(["a"], dtype="category")
     with pytest.raises(ValueError):
         cudf.concat([df1, df2])

diff --git a/python/cudf/cudf/tests/test_joining.py b/python/cudf/cudf/tests/test_joining.py
@@ -821,17 +821,17 @@ def test_join_empty_table_dtype():
     "column_a",
     [
         (
-            pd.Series([None, 1, 2, 3, 4, 5, 6, 7], dtype=np.float_),
-            pd.Series([8, 9, 10, 11, 12, None, 14, 15], dtype=np.float_),
+            pd.Series([None, 1, 2, 3, 4, 5, 6, 7], dtype=np.float64),
+            pd.Series([8, 9, 10, 11, 12, None, 14, 15], dtype=np.float64),
         )
     ],
 )
 @pytest.mark.parametrize(
     "column_b",
     [
         (
-            pd.Series([0, 1, 0, None, 1, 0, 0, 0], dtype=np.float_),
-            pd.Series([None, 1, 2, 1, 2, 2, 0, 0], dtype=np.float_),
+            pd.Series([0, 1, 0, None, 1, 0, 0, 0], dtype=np.float64),
+            pd.Series([None, 1, 2, 1, 2, 2, 0, 0], dtype=np.float64),
         )
     ],
 )