Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve coverage of dask-cudf's groupby aggregation, add tests for `d…
…ropna` support (#10449) This PR does the following: - Make sure that all of dask-cudf's `SUPPORTED_AGGS` have an overriding method for upstream Dask's series / dataframe groupby methods - Add tests comparing dask-cudf's `dropna` support to upstream Dask's, as at the moment we are only comparing against cuDF - Fix the resulting failures of these changes (by properly parsing `self.dropna` in dask-cudf's groupby code) As a side note, I think that a larger rethinking of dask-cudf's groupby would pay off well, as currently it seems like we have some "duplicate" tests and aren't really able to discern if `groupby_agg` was called for a supported aggregation Authors: - Charles Blackmon-Luca (https://github.com/charlesbluca) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Richard (Rick) Zamora (https://github.com/rjzamora) URL: #10449
- Loading branch information