Skip to content

Commit

Permalink
Avoid skbuild 0.17.2 which affected the cmake -DPython_LIBRARY string (
Browse files Browse the repository at this point in the history
…#13188)

We see builds are failing in cuDF, possibly because of a missing `-DPython_LIBRARY` string in the CMake command: https://github.com/rapidsai/cudf/actions/runs/4750812902/jobs/8439338686#step:11:861

This may be a result of the scikit-build release 0.17.2: https://github.com/scikit-build/scikit-build/pull/943/files

Authors:
  - Sevag H (https://github.com/sevagh)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #13188
  • Loading branch information
sevagh authored Apr 20, 2023
1 parent 9d36716 commit e437956
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-118_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ dependencies:
- pytorch<1.12.0
- rmm==23.6.*
- s3fs>=2022.3.0
- scikit-build>=0.13.1
- scikit-build>=0.13.1,<0.17.2
- scipy
- spdlog>=1.11.0,<1.12
- sphinx
Expand Down
2 changes: 1 addition & 1 deletion dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ dependencies:
common:
- output_types: [conda, requirements, pyproject]
packages:
- scikit-build>=0.13.1
- scikit-build>=0.13.1,<0.17.2
- rmm==23.6.*
- output_types: conda
packages:
Expand Down
2 changes: 1 addition & 1 deletion python/cudf/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ requires = [
"protoc-wheel",
"pyarrow==11.0.0.*",
"rmm==23.6.*",
"scikit-build>=0.13.1",
"scikit-build>=0.13.1,<0.17.2",
"setuptools",
"wheel",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.
Expand Down

0 comments on commit e437956

Please sign in to comment.