Skip to content

Commit

Permalink
Clean up ORC reader benchmarks with NVBench (#11543)
Browse files Browse the repository at this point in the history
Issue #10941

This PR rewrites the existing ORC reader benchmarks with nvbench w.r.t. #7960. It improves the `input` test case in which all data types were benchmarked with all compression and IO types. By splitting `input` into `decode` and `io_compression`, it reduces the number of test cases from 112 to 44.

The PR also removes the current `row_selection` test suite.

Authors:
  - Yunsong Wang (https://github.com/PointKernel)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Vukasin Milovanovic (https://github.com/vuule)

URL: #11543
  • Loading branch information
PointKernel authored Aug 23, 2022
1 parent 2c06e51 commit e431440
Show file tree
Hide file tree
Showing 4 changed files with 400 additions and 206 deletions.
2 changes: 1 addition & 1 deletion cpp/benchmarks/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ ConfigureBench(PARQUET_READER_BENCH io/parquet/parquet_reader.cpp)

# ##################################################################################################
# * orc reader benchmark --------------------------------------------------------------------------
ConfigureBench(ORC_READER_BENCH io/orc/orc_reader.cpp)
ConfigureNVBench(ORC_READER_NVBENCH io/orc/orc_reader_input.cpp io/orc/orc_reader_options.cpp)

# ##################################################################################################
# * csv reader benchmark --------------------------------------------------------------------------
Expand Down
205 changes: 0 additions & 205 deletions cpp/benchmarks/io/orc/orc_reader.cpp

This file was deleted.

Loading

0 comments on commit e431440

Please sign in to comment.