Removed unused variables. Misc cleanup.

rapidsai · May 17, 2021 · d58938d · d58938d
1 parent cc26de7
commit d58938d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/cpp/src/column/column_factories.cpp b/cpp/src/column/column_factories.cpp
@@ -172,4 +172,4 @@ std::unique_ptr<column> make_dictionary_from_scalar(scalar const& s,
     0);
 }
 
-}  // namespace cudf
+}  // namespace cudf
diff --git a/cpp/src/scalar/scalar.cpp b/cpp/src/scalar/scalar.cpp
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-#include "structs/utilities.hpp"
+#include <structs/utilities.hpp>
 
 #include <cudf/column/column.hpp>
 #include <cudf/detail/utilities/vector_factories.hpp>

diff --git a/cpp/src/structs/structs_column_factories.cu b/cpp/src/structs/structs_column_factories.cu
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-#include "structs/utilities.hpp"
+#include <structs/utilities.hpp>
 
 #include <cudf/column/column_factories.hpp>
 #include <cudf/types.hpp>

diff --git a/cpp/tests/scalar/factories_test.cpp b/cpp/tests/scalar/factories_test.cpp
@@ -177,18 +177,16 @@ TEST_F(StructScalarFactory, Basic)
 
   // table_view constructor
   {
-    auto sc    = cudf::make_struct_scalar(cudf::table_view{children});
-    auto s     = static_cast<cudf::scalar_type_t<cudf::struct_view>*>(sc.get());
-    auto sview = s->view();
+    auto sc = cudf::make_struct_scalar(cudf::table_view{children});
+    auto s  = static_cast<cudf::scalar_type_t<cudf::struct_view>*>(sc.get());
     EXPECT_TRUE(s->is_valid());
     CUDF_TEST_EXPECT_TABLES_EQUIVALENT(cudf::table_view{children}, s->view());
   }
 
   // host_span constructor
   {
-    auto sc    = cudf::make_struct_scalar(cudf::host_span<cudf::column_view const>{children});
-    auto s     = static_cast<cudf::scalar_type_t<cudf::struct_view>*>(sc.get());
-    auto sview = s->view();
+    auto sc = cudf::make_struct_scalar(cudf::host_span<cudf::column_view const>{children});
+    auto s  = static_cast<cudf::scalar_type_t<cudf::struct_view>*>(sc.get());
     EXPECT_TRUE(s->is_valid());
     CUDF_TEST_EXPECT_TABLES_EQUIVALENT(cudf::table_view{children}, s->view());
   }
-Original file line number
+Diff line change
@@ Expand Up @@
 );
     }
-    }  // namespace cudf
+    }  // namespace cudf