updating from review comments

rapidsai · Mar 15, 2021 · d2584e6 · d2584e6
1 parent 2fd6652
commit d2584e6
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
@@ -257,6 +257,7 @@ add_library(cudf
     src/lists/copying/gather.cu
     src/lists/copying/segmented_gather.cu
     src/lists/count_elements.cu
+    src/lists/explode.cu
     src/lists/extract.cu
     src/lists/lists_column_factories.cu
     src/lists/lists_column_view.cu
@@ -285,7 +286,6 @@ add_library(cudf
     src/replace/nulls.cu
     src/replace/replace.cu
     src/reshape/byte_cast.cu
-    src/reshape/explode.cu
     src/reshape/interleave_columns.cu
     src/reshape/tile.cu
     src/rolling/grouped_rolling.cu

diff --git a/cpp/include/cudf/lists/explode.hpp b/cpp/include/cudf/lists/explode.hpp
@@ -16,10 +16,10 @@
 
 #pragma once
 
-//#include <cudf/column/column.hpp>
-//#include <cudf/table/table_view.hpp>
-//#include <cudf/types.hpp>
-//#include <memory>
+#include <cudf/column/column.hpp>
+#include <cudf/table/table_view.hpp>
+#include <cudf/types.hpp>
+#include <memory>
 
 namespace cudf {
 

diff --git a/cpp/src/reshape/explode.cu → cpp/src/lists/explode.cu b/cpp/src/reshape/explode.cu → cpp/src/lists/explode.cu
@@ -17,8 +17,8 @@
 #include <cudf/column/column_device_view.cuh>
 #include <cudf/detail/gather.cuh>
 #include <cudf/detail/nvtx/ranges.hpp>
+#include <cudf/lists/explode.hpp>
 #include <cudf/lists/lists_column_view.hpp>
-#include <cudf/reshape.hpp>
 #include <cudf/table/table.hpp>
 #include <cudf/utilities/type_dispatcher.hpp>
 

diff --git a/cpp/tests/lists/explode_tests.cpp b/cpp/tests/lists/explode_tests.cpp
@@ -14,14 +14,14 @@
  * limitations under the License.
  */
 
-#include <cudf/detail/iterator.cuh>
-#include <cudf/lists/explode.hpp>
-
 #include <cudf_test/base_fixture.hpp>
 #include <cudf_test/column_wrapper.hpp>
 #include <cudf_test/table_utilities.hpp>
 #include <cudf_test/type_lists.hpp>
 
+#include <cudf/detail/iterator.cuh>
+#include <cudf/lists/explode.hpp>
+
 using namespace cudf::test;
 using FCW = fixed_width_column_wrapper<int32_t>;
 using LCW = lists_column_wrapper<int32_t>;