address reviews

rapidsai · Sep 7, 2021 · cfac5b9 · cfac5b9
1 parent c0435e1
commit cfac5b9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/python/cudf/cudf/tests/test_dataframe.py b/python/cudf/cudf/tests/test_dataframe.py
@@ -1241,8 +1241,7 @@ def test_dataframe_concat_different_numerical_columns(dtype1, dtype2):
     else:
         pres = pd.concat([df1, df2])
         gres = cudf.concat([cudf.from_pandas(df1), cudf.from_pandas(df2)])
-        # Pandas 1.3.2+ returns mixed `object` dtype result.
-        assert_eq(cudf.from_pandas(pres.astype(gres.dtypes)), gres)
+        assert_eq(pres, gres, check_dtype=False)
 
 
 def test_dataframe_concat_different_column_types():

diff --git a/python/cudf/cudf/tests/test_index.py b/python/cudf/cudf/tests/test_index.py
@@ -1873,12 +1873,9 @@ def test_index_fillna(data, fill_value):
     pdi = pd.Index(data)
     gdi = cudf.Index(data)
 
-    if isinstance(gdi, cudf.Int64Index) and isinstance(pdi, pd.Float64Index):
-        assert_eq(
-            pdi.fillna(fill_value).astype(gdi.dtype), gdi.fillna(fill_value)
-        )
-    else:
-        assert_eq(pdi.fillna(fill_value), gdi.fillna(fill_value))
+    assert_eq(
+        pdi.fillna(fill_value), gdi.fillna(fill_value), exact=False
+    )  # Int64Index v/s Float64Index
 
 
 @pytest.mark.parametrize(