Skip to content

Commit

Permalink
Fix make_offsets_child_column usage in cudf::strings::detail::shift (#…
Browse files Browse the repository at this point in the history
…15630)

Fixes the `cudf::strings::detail::shift()` function to use the correct `make_offsets_child_column` function to support large strings.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Muhammad Haseeb (https://github.com/mhaseeb123)
  - Bradley Dice (https://github.com/bdice)

URL: #15630
  • Loading branch information
davidwendt authored May 3, 2024
1 parent a27feab commit c60860d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cpp/src/strings/copying/shift.cu
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
#include <cudf/detail/copy.hpp>
#include <cudf/detail/get_value.cuh>
#include <cudf/detail/iterator.cuh>
#include <cudf/detail/sizes_to_offsets_iterator.cuh>
#include <cudf/strings/detail/copying.hpp>
#include <cudf/strings/detail/strings_children.cuh>
#include <cudf/strings/detail/utilities.hpp>

#include <rmm/cuda_stream_view.hpp>
Expand Down Expand Up @@ -104,8 +104,8 @@ std::unique_ptr<column> shift(strings_column_view const& input,
auto const d_input = column_device_view::create(input.parent(), stream);
auto sizes_itr = cudf::detail::make_counting_transform_iterator(
0, output_sizes_fn{*d_input, d_fill_str, offset});
auto [offsets_column, total_bytes] =
cudf::detail::make_offsets_child_column(sizes_itr, sizes_itr + input.size(), stream, mr);
auto [offsets_column, total_bytes] = cudf::strings::detail::make_offsets_child_column(
sizes_itr, sizes_itr + input.size(), stream, mr);
auto offsets_view = offsets_column->view();

// compute the shift-offset for the output characters child column
Expand Down

0 comments on commit c60860d

Please sign in to comment.