Skip to content

Commit

Permalink
Refactor Parquet writer options and builders (#15831)
Browse files Browse the repository at this point in the history
Adding options to the Parquet writer is made somewhat tedious by the duplication of code between the two current sets of options/builder classes; one each for the chunked and non-chunked Parquet writers. This PR pulls common options into a parent options class, and common setters into a parent builder class. The builder parent uses CRTP to allow chaining of options.

Authors:
  - Ed Seidl (https://github.com/etseidl)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Mike Wilson (https://github.com/hyperbolic2346)
  - Muhammad Haseeb (https://github.com/mhaseeb123)
  - Vukasin Milovanovic (https://github.com/vuule)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Vukasin Milovanovic (https://github.com/vuule)
  - Muhammad Haseeb (https://github.com/mhaseeb123)
  - Mike Wilson (https://github.com/hyperbolic2346)

URL: #15831
  • Loading branch information
etseidl authored Jun 10, 2024
1 parent bfad68c commit c02260f
Show file tree
Hide file tree
Showing 3 changed files with 410 additions and 940 deletions.
Loading

0 comments on commit c02260f

Please sign in to comment.