Skip to content

Commit

Permalink
Unpin dask and distributed for development (#12302)
Browse files Browse the repository at this point in the history
This PR unpins `dask` and `distributed` to `2022.12.0+` for `23.02` development.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Charles Blackmon-Luca (https://github.com/charlesbluca)

URL: #12302
  • Loading branch information
galipremsagar authored Dec 12, 2022
1 parent e9d52a4 commit b448ac2
Show file tree
Hide file tree
Showing 15 changed files with 19 additions and 51 deletions.
4 changes: 2 additions & 2 deletions ci/benchmark/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ export GBENCH_BENCHMARKS_DIR="$WORKSPACE/cpp/build/gbenchmarks/"
export LIBCUDF_KERNEL_CACHE_PATH="$HOME/.jitify-cache"

# Dask & Distributed option to install main(nightly) or `conda-forge` packages.
export INSTALL_DASK_MAIN=0
export INSTALL_DASK_MAIN=1

# Dask version to install when `INSTALL_DASK_MAIN=0`
export DASK_STABLE_VERSION="2022.11.1"
export DASK_STABLE_VERSION="2022.12.0"

function remove_libcudf_kernel_cache_dir {
EXITCODE=$?
Expand Down
2 changes: 1 addition & 1 deletion ci/cpu/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export CONDA_BLD_DIR="$WORKSPACE/.conda-bld"

# Whether to keep `dask/label/dev` channel in the env. If INSTALL_DASK_MAIN=0,
# `dask/label/dev` channel is removed.
export INSTALL_DASK_MAIN=0
export INSTALL_DASK_MAIN=1

# Switch to project root; also root of repo checkout
cd "$WORKSPACE"
Expand Down
4 changes: 2 additions & 2 deletions ci/gpu/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ export MINOR_VERSION=`echo $GIT_DESCRIBE_TAG | grep -o -E '([0-9]+\.[0-9]+)'`
unset GIT_DESCRIBE_TAG

# Dask & Distributed option to install main(nightly) or `conda-forge` packages.
export INSTALL_DASK_MAIN=0
export INSTALL_DASK_MAIN=1

# Dask version to install when `INSTALL_DASK_MAIN=0`
export DASK_STABLE_VERSION="2022.11.1"
export DASK_STABLE_VERSION="2022.12.0"

# ucx-py version
export UCX_PY_VERSION='0.30.*'
Expand Down
4 changes: 2 additions & 2 deletions conda/environments/all_cuda-115_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ dependencies:
- cxx-compiler
- cython>=0.29,<0.30
- dask-cuda=23.02.*
- dask>=2022.11.1
- distributed>=2022.11.1
- dask>=2022.12.0
- distributed>=2022.12.0
- dlpack>=0.5,<0.6.0a0
- doxygen=1.8.20
- fastavro>=0.22.9
Expand Down
4 changes: 2 additions & 2 deletions conda/recipes/custreamz/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ requirements:
- python
- streamz
- cudf ={{ version }}
- dask==2022.11.1
- distributed==2022.11.1
- dask>=2022.12.0
- distributed>=2022.12.0
- python-confluent-kafka >=1.7.0,<1.8.0a0
- cudf_kafka ={{ version }}

Expand Down
8 changes: 4 additions & 4 deletions conda/recipes/dask-cudf/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@ requirements:
host:
- python
- cudf ={{ version }}
- dask==2022.11.1
- distributed==2022.11.1
- dask>=2022.12.0
- distributed>=2022.12.0
- cudatoolkit ={{ cuda_version }}
run:
- python
- cudf ={{ version }}
- dask==2022.11.1
- distributed==2022.11.1
- dask>=2022.12.0
- distributed>=2022.12.0
- {{ pin_compatible('cudatoolkit', max_pin='x', min_pin='x') }}

# TODO: Remove the linux64 tags on tests after disabling gpuCI / Jenkins
Expand Down
4 changes: 2 additions & 2 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,8 @@ dependencies:
- output_types: [conda, requirements]
packages:
- cachetools
- dask>=2022.11.1
- distributed>=2022.11.1
- dask>=2022.12.0
- distributed>=2022.12.0
- fsspec>=0.6.0
- numba>=0.56.2
- numpy
Expand Down
9 changes: 0 additions & 9 deletions python/dask_cudf/dask_cudf/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,8 @@

import numpy as np
import pandas as pd
from packaging.version import parse as parse_version
from tlz import partition_all

import dask
import dask.dataframe.optimize
from dask import dataframe as dd
from dask.base import normalize_token, tokenize
from dask.dataframe.core import (
Expand All @@ -30,12 +27,6 @@
from dask_cudf.accessors import ListMethods, StructMethods
from dask_cudf.sorting import _get_shuffle_type

DASK_BACKEND_SUPPORT = parse_version(dask.__version__) >= parse_version(
"2022.10.0"
)
# TODO: Remove DASK_BACKEND_SUPPORT throughout codebase
# when dask_cudf is pinned to dask>=2022.10.0


class _Frame(dd.core._Frame, OperatorMethodMixin):
"""Superclass for DataFrame and Series
Expand Down
8 changes: 2 additions & 6 deletions python/dask_cudf/dask_cudf/groupby.py
Original file line number Diff line number Diff line change
Expand Up @@ -219,9 +219,7 @@ def aggregate(self, arg, split_every=None, split_out=1, shuffle=None):
arg,
split_every=split_every,
split_out=split_out,
# TODO: Change following line to `shuffle=shuffle,`
# when dask_cudf is pinned to dask>2022.8.0
**({} if shuffle is None else {"shuffle": shuffle}),
shuffle=shuffle,
)


Expand Down Expand Up @@ -351,9 +349,7 @@ def aggregate(self, arg, split_every=None, split_out=1, shuffle=None):
arg,
split_every=split_every,
split_out=split_out,
# TODO: Change following line to `shuffle=shuffle,`
# when dask_cudf is pinned to dask>2022.8.0
**({} if shuffle is None else {"shuffle": shuffle}),
shuffle=shuffle,
)


Expand Down
4 changes: 0 additions & 4 deletions python/dask_cudf/dask_cudf/io/tests/test_csv.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@
import dask_cudf


@pytest.mark.skipif(
not dask_cudf.core.DASK_BACKEND_SUPPORT,
reason="No backend-dispatch support",
)
def test_csv_roundtrip_backend_dispatch(tmp_path):
# Test ddf.read_csv cudf-backend dispatch
df = cudf.DataFrame({"x": [1, 2, 3, 4], "id": ["a", "b", "c", "d"]})
Expand Down
4 changes: 0 additions & 4 deletions python/dask_cudf/dask_cudf/io/tests/test_json.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
import dask_cudf


@pytest.mark.skipif(
not dask_cudf.core.DASK_BACKEND_SUPPORT,
reason="No backend-dispatch support",
)
def test_read_json_backend_dispatch(tmp_path):
# Test ddf.read_json cudf-backend dispatch
df1 = dask.datasets.timeseries(
Expand Down
4 changes: 0 additions & 4 deletions python/dask_cudf/dask_cudf/io/tests/test_orc.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@
sample_orc = os.path.join(cur_dir, "data/orc/sample.orc")


@pytest.mark.skipif(
not dask_cudf.core.DASK_BACKEND_SUPPORT,
reason="No backend-dispatch support",
)
def test_read_orc_backend_dispatch():
# Test ddf.read_orc cudf-backend dispatch
df1 = cudf.read_orc(sample_orc)
Expand Down
4 changes: 0 additions & 4 deletions python/dask_cudf/dask_cudf/io/tests/test_parquet.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ def _divisions(setting):
return {"gather_statistics": setting}


@pytest.mark.skipif(
not dask_cudf.core.DASK_BACKEND_SUPPORT,
reason="No backend-dispatch support",
)
def test_roundtrip_backend_dispatch(tmpdir):
# Test ddf.read_parquet cudf-backend dispatch
tmpdir = str(tmpdir)
Expand Down
3 changes: 0 additions & 3 deletions python/dask_cudf/dask_cudf/tests/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
import dask_cudf as dgd


@pytest.mark.skipif(
not dgd.core.DASK_BACKEND_SUPPORT, reason="No backend-dispatch support"
)
def test_from_dict_backend_dispatch():
# Test ddf.from_dict cudf-backend dispatch
np.random.seed(0)
Expand Down
4 changes: 2 additions & 2 deletions python/dask_cudf/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
cuda_suffix = os.getenv("RAPIDS_PY_WHEEL_CUDA_SUFFIX", default="")

install_requires = [
"dask==2022.11.1",
"distributed==2022.11.1",
"dask>=2022.12.0",
"distributed>=2022.12.0",
"fsspec>=0.6.0",
"numpy",
"pandas>=1.0,<1.6.0dev0",
Expand Down

0 comments on commit b448ac2

Please sign in to comment.