Skip to content

Commit

Permalink
min_rows and num_rows are swapped in ComputePageSizes declaration in …
Browse files Browse the repository at this point in the history
…Parquet reader (#12886)

Arguments are swapped in declaration (and thus docs as well). Args are passed as required by the definition when `ComputePageSizes` is called.

Authors:
  - Ed Seidl (https://github.com/etseidl)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Yunsong Wang (https://github.com/PointKernel)

URL: #12886
  • Loading branch information
etseidl authored Mar 6, 2023
1 parent 618194d commit a7ede21
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cpp/src/io/parquet/parquet_gpu.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -445,8 +445,8 @@ void BuildStringDictionaryIndex(ColumnChunkDesc* chunks,
*
* @param pages All pages to be decoded
* @param chunks All chunks to be decoded
* @param num_rows Maximum number of rows to read
* @param min_rows crop all rows below min_row
* @param num_rows Maximum number of rows to read
* @param compute_num_rows If set to true, the num_rows field in PageInfo will be
* computed
* @param compute_string_sizes If set to true, the str_bytes field in PageInfo will
Expand All @@ -455,8 +455,8 @@ void BuildStringDictionaryIndex(ColumnChunkDesc* chunks,
*/
void ComputePageSizes(hostdevice_vector<PageInfo>& pages,
hostdevice_vector<ColumnChunkDesc> const& chunks,
size_t num_rows,
size_t min_row,
size_t num_rows,
bool compute_num_rows,
bool compute_string_sizes,
rmm::cuda_stream_view stream);
Expand Down

0 comments on commit a7ede21

Please sign in to comment.