Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Mark dlpack tensor deleter as noexcept to match PyCapsule_Destructor …
…signature. (#12921) This is a fix for a Cython problem that appears when building with Cython 3.0.0 beta 1. There are a bunch of warnings I'd like to fix as well, but this is the only hard error. The fix is to use `noexcept` in the deleter definition. ``` Error compiling Cython file: ------------------------------------------------------------ ... ) return pycapsule.PyCapsule_New( dlpack_tensor, 'dltensor', dlmanaged_tensor_pycapsule_deleter ^ ------------------------------------------------------------ /home/bdice/code/cudf/python/cudf/cudf/_lib/interop.pyx:69:8: Cannot assign type 'void (object) except *' to 'PyCapsule_Destructor' ``` Authors: - Bradley Dice (https://github.com/bdice) - Ashwin Srinath (https://github.com/shwina) Approvers: - https://github.com/jakirkham - Lawrence Mitchell (https://github.com/wence-) - Ashwin Srinath (https://github.com/shwina) URL: #12921
- Loading branch information