Skip to content

Commit

Permalink
Skip pandas unit tests that crash pytest workers in cudf.pandas (#1…
Browse files Browse the repository at this point in the history
…5521)

While enabling some ignored pandas unit tests for `cudf.pandas`, tests were passing in the specified 30 minute allotment, but it appears some of these newly enabled tests are still causing pytest workers to crash. I think it's OK to lose some testing coverage of these tests if it means test runners are not crashing

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: #15521
  • Loading branch information
mroeschke authored Apr 13, 2024
1 parent f5df665 commit 9cc87f0
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion python/cudf/cudf/pandas/scripts/run-pandas-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,15 @@ and not test_s3_roundtrip_for_dir[partition_col0] \
and not test_s3_roundtrip_for_dir[partition_col1] \
and not test_s3_roundtrip"

TEST_THAT_CRASH_PYTEST_WORKERS="not test_bitmasks_pyarrow \
and not test_large_string_pyarrow \
and not test_interchange_from_corrected_buffer_dtypes \
and not test_eof_states"

# TODO: Remove "not db" once a postgres & mysql container is set up on the CI
PANDAS_CI="1" timeout 30m python -m pytest -p cudf.pandas \
-v -m "not single_cpu and not db" \
-k "not test_to_parquet_gcs_new_file and not test_qcut_nat and not test_add and not test_ismethods and $TEST_THAT_NEED_MOTO_SERVER" \
-k "not test_to_parquet_gcs_new_file and not test_qcut_nat and not test_add and not test_ismethods and $TEST_THAT_NEED_MOTO_SERVER and $TEST_THAT_CRASH_PYTEST_WORKERS" \
--import-mode=importlib \
${PYTEST_IGNORES} \
"$@" || [ $? = 1 ] # Exit success if exit code was 1 (permit test failures but not other errors)
Expand Down

0 comments on commit 9cc87f0

Please sign in to comment.