Skip to content

Commit

Permalink
Disable very large column gtest for contiguous-split (#11706)
Browse files Browse the repository at this point in the history
Disables a `ContiguousSplitUntypedTest` that simply creates a very large (over 3GB) column to test the output buffer size does not overflow. The gtests ends requiring 25GB of device memory when used with the arena allocator as mentioned in #11249. Very large columns like this should be not part of the unit test for libcudf.
This PR disables the test so it can be available for testing on specific conditions outside of CI.

Closes #11249

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Bradley Dice (https://github.com/bdice)

URL: #11706
  • Loading branch information
davidwendt authored Sep 22, 2022
1 parent 5430fbd commit 9363095
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cpp/tests/copying/split_tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1360,7 +1360,8 @@ TEST_F(ContiguousSplitUntypedTest, ValidityEdgeCase)
}
}

TEST_F(ContiguousSplitUntypedTest, CalculationOverflow)
// This test requires about 25GB of device memory when used with the arena allocator
TEST_F(ContiguousSplitUntypedTest, DISABLED_VeryLargeColumnTest)
{
// tests an edge case where buf.elements * buf.element_size overflows an INT32.
auto col = cudf::make_fixed_width_column(
Expand Down

0 comments on commit 9363095

Please sign in to comment.