address review comments (davidwendt)

rapidsai · May 21, 2022 · 7b45716 · 7b45716
1 parent 8601b8d
commit 7b45716
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/cpp/include/cudf/detail/copy_if_else.cuh b/cpp/include/cudf/detail/copy_if_else.cuh
@@ -51,7 +51,7 @@ __launch_bounds__(block_size) __global__
   // begin/end indices for the column data
   size_type begin = 0;
   size_type end   = out.size();
-  // warp indices.  since 1 warp == 32 threads == sizeof(bit_mask_t) * 8,
+  // warp indices.  since 1 warp == 32 threads == sizeof(bitmask_type) * 8,
   // each warp will process one (32 bit) of the validity mask via
   // __ballot_sync()
   size_type warp_begin = cudf::word_index(begin);

diff --git a/cpp/include/cudf/types.hpp b/cpp/include/cudf/types.hpp
@@ -32,13 +32,8 @@
  * @brief Type declarations for libcudf.
  */
 
-// FIXME: where is this used? TODO: remove if unused.
-namespace bit_mask {
-using bit_mask_t = uint32_t;
-}
-
 // Forward declarations
-/// @cond FORWARD_DECLARATIONS
+/// @cond
 namespace rmm {
 class device_buffer;
 namespace mr {
@@ -247,7 +242,7 @@ class data_type {
   data_type()                 = default;
   ~data_type()                = default;
   data_type(data_type const&) = default;  ///< Copy constructor
-  data_type(data_type&&)      = default;  ///<  Move constructor
+  data_type(data_type&&)      = default;  ///< Move constructor
 
   /**
    * @brief Copy assignment operator for data_type