Skip to content

Commit

Permalink
add comment about limit crossover calculation
Browse files Browse the repository at this point in the history
  • Loading branch information
davidwendt committed Dec 6, 2023
1 parent 6bdc601 commit 6cfdfa7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cpp/tests/copying/concatenate_tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,10 @@ TEST_F(StringColumnTest, ConcatenateManyColumns)

TEST_F(StringColumnTest, ConcatenateTooLarge)
{
std::string big_str(1000000, 'a');
std::string big_str(1000000, 'a'); // 1 million bytes x 5 = 5 million bytes
cudf::test::strings_column_wrapper input{big_str, big_str, big_str, big_str, big_str};
std::vector<cudf::column_view> input_cols;
// 5 millions bytes x 500 = 2.5GB > std::numeric_limits<size_type>::max()
for (int i = 0; i < 500; ++i) {
input_cols.push_back(input);
}
Expand Down

0 comments on commit 6cfdfa7

Please sign in to comment.