Skip to content

Commit

Permalink
Include <optional> in headers that use std::optional (#10044)
Browse files Browse the repository at this point in the history
Detected when compiling with gcc-11 where <optional> wasn't being brought in by other standard headers

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - David Wendt (https://github.com/davidwendt)
  - Nghia Truong (https://github.com/ttnghia)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #10044
  • Loading branch information
robertmaynard authored Jan 20, 2022
1 parent f041034 commit 6bbe2e8
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cpp/benchmarks/common/generate_benchmark_input.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020-2021, NVIDIA CORPORATION.
* Copyright (c) 2020-2022, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -31,6 +31,7 @@

#include <future>
#include <memory>
#include <optional>
#include <random>
#include <thread>
#include <vector>
Expand Down
2 changes: 2 additions & 0 deletions cpp/include/cudf/strings/repeat_strings.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
#include <cudf/scalar/scalar.hpp>
#include <cudf/strings/strings_column_view.hpp>

#include <optional>

namespace cudf {
namespace strings {
/**
Expand Down
2 changes: 2 additions & 0 deletions cpp/include/cudf/strings/replace_re.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
#include <cudf/strings/regex/flags.hpp>
#include <cudf/strings/strings_column_view.hpp>

#include <optional>

namespace cudf {
namespace strings {
/**
Expand Down
2 changes: 2 additions & 0 deletions cpp/src/io/utilities/trie.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

#include <cudf/utilities/span.hpp>

#include <optional>

namespace cudf {
namespace detail {
static constexpr char trie_terminating_character = '\n';
Expand Down

0 comments on commit 6bbe2e8

Please sign in to comment.