Skip to content

Commit

Permalink
Fix memcheck script to execute only _TEST files found in bin/gtests/l…
Browse files Browse the repository at this point in the history
…ibcudf (#13006)

The nightly runs of `compute-sanitizer` started failing due to the test script trying to execute some new extra files found in the `$CONDA_PREFIX"/bin/gtests/libcudf/` directory. This change ensures only files ending in `_TEST` are executed by `compute-sanitizer`.

For reference errors are here: https://github.com/rapidsai/cudf/actions/runs/4508267264/jobs/7936800047
Example:
```
Running compute-sanitizer on CTestTestfile.cmake
========= COMPUTE-SANITIZER
========= Error: Target application terminated before first instrumented API call
```

Follow on issue/PR could explore adding a special make option to execute `compute-sanitizer` only on test files.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #13006
  • Loading branch information
davidwendt authored Mar 24, 2023
1 parent ba8116a commit 698fcf6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ci/test_cpp_memcheck.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ set +e
rapids-logger "Memcheck gtests with rmm_mode=cuda"
export GTEST_CUDF_RMM_MODE=cuda
COMPUTE_SANITIZER_CMD="compute-sanitizer --tool memcheck"
for gt in "$CONDA_PREFIX"/bin/gtests/libcudf/* ; do
for gt in "$CONDA_PREFIX"/bin/gtests/libcudf/*_TEST ; do
test_name=$(basename ${gt})
if [[ "$test_name" == "ERROR_TEST" ]] || [[ "$test_name" == "STREAM_IDENTIFICATION_TEST" ]]; then
continue
Expand Down

0 comments on commit 698fcf6

Please sign in to comment.