Skip to content

Commit

Permalink
Avoid circular cimports in _lib/cpp/reduce.pxd (#14125)
Browse files Browse the repository at this point in the history
This Cython modules contains some cimports from higher-level modules than it should, which introduces the possibility for circular import issues. Also it contains an unused import of DeviceScalar that can cause similar issues.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)

URL: #14125
  • Loading branch information
vyasr authored Sep 20, 2023
1 parent 97501d8 commit 63d197f
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions python/cudf/cudf/_lib/cpp/reduce.pxd
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
# Copyright (c) 2020-2022, NVIDIA CORPORATION.
# Copyright (c) 2020-2023, NVIDIA CORPORATION.

from libcpp.memory cimport unique_ptr
from libcpp.utility cimport pair

from cudf._lib.aggregation cimport reduce_aggregation, scan_aggregation
from cudf._lib.cpp.aggregation cimport reduce_aggregation, scan_aggregation
from cudf._lib.cpp.column.column cimport column
from cudf._lib.cpp.column.column_view cimport column_view
from cudf._lib.cpp.scalar.scalar cimport scalar
from cudf._lib.cpp.types cimport data_type
from cudf._lib.scalar cimport DeviceScalar


cdef extern from "cudf/reduction.hpp" namespace "cudf" nogil:
Expand Down

0 comments on commit 63d197f

Please sign in to comment.