Allow decimal128 cast and add tests

rapidsai · Nov 23, 2021 · 5e4b79b · 5e4b79b
1 parent 85df759
commit 5e4b79b
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 6 deletions.
diff --git a/java/src/main/native/src/ColumnViewJni.cpp b/java/src/main/native/src/ColumnViewJni.cpp
@@ -904,26 +904,39 @@ JNIEXPORT jlong JNICALL Java_ai_rapids_cudf_ColumnView_castTo(JNIEnv *env, jclas
     }
     if (n_data_type.id() == cudf::type_id::STRING) {
       switch (column->type().id()) {
-        case cudf::type_id::BOOL8: result = cudf::strings::from_booleans(*column); break;
+        case cudf::type_id::BOOL8: 
+          result = cudf::strings::from_booleans(*column); 
+          break;
         case cudf::type_id::FLOAT32:
-        case cudf::type_id::FLOAT64: result = cudf::strings::from_floats(*column); break;
+        case cudf::type_id::FLOAT64: 
+          result = cudf::strings::from_floats(*column); 
+          break;
         case cudf::type_id::INT8:
         case cudf::type_id::UINT8:
         case cudf::type_id::INT16:
         case cudf::type_id::UINT16:
         case cudf::type_id::INT32:
         case cudf::type_id::UINT32:
         case cudf::type_id::INT64:
-        case cudf::type_id::UINT64: result = cudf::strings::from_integers(*column); break;
+        case cudf::type_id::UINT64: 
+          result = cudf::strings::from_integers(*column); 
+          break;
         case cudf::type_id::DECIMAL32:
-        case cudf::type_id::DECIMAL64: result = cudf::strings::from_fixed_point(*column); break;
+        case cudf::type_id::DECIMAL64: 
+        case cudf::type_id::DECIMAL128:
+          result = cudf::strings::from_fixed_point(*column); 
+          break;
         default: JNI_THROW_NEW(env, "java/lang/IllegalArgumentException", "Invalid data type", 0);
       }
     } else if (column->type().id() == cudf::type_id::STRING) {
       switch (n_data_type.id()) {
-        case cudf::type_id::BOOL8: result = cudf::strings::to_booleans(*column); break;
+        case cudf::type_id::BOOL8: 
+          result = cudf::strings::to_booleans(*column); 
+          break;
         case cudf::type_id::FLOAT32:
-        case cudf::type_id::FLOAT64: result = cudf::strings::to_floats(*column, n_data_type); break;
+        case cudf::type_id::FLOAT64: 
+          result = cudf::strings::to_floats(*column, n_data_type); 
+          break;
         case cudf::type_id::INT8:
         case cudf::type_id::UINT8:
         case cudf::type_id::INT16:

diff --git a/java/src/test/java/ai/rapids/cudf/ColumnVectorTest.java b/java/src/test/java/ai/rapids/cudf/ColumnVectorTest.java
@@ -3370,6 +3370,22 @@ void testFixedWidthCast() {
     }
   }
 
+  @Test
+  void testCastBigDecimalToString() {
+    BigDecimal[] bigValues = {new BigDecimal("923121331938210123.321"),
+        new BigDecimal("9223372036854775808.191"),
+        new BigDecimal("9328323982309091029831.002")
+    };
+
+    try (ColumnVector cv = ColumnVector.fromDecimals(bigValues);
+         ColumnVector values = cv.castTo(DType.STRING);
+         ColumnVector expected = ColumnVector.fromStrings("923121331938210123.321",
+             "9223372036854775808.191",
+             "9328323982309091029831.002")) {
+      assertColumnsAreEqual(expected, values);
+    }
+  }
+
   @Test
   void testCastStringToBigDecimal() {
     String[] bigValues = {"923121331938210123.321",