Skip to content

Commit

Permalink
Fix links to Google test [skip CI]
Browse files Browse the repository at this point in the history
  • Loading branch information
vyasr authored Apr 14, 2021
1 parent 9617fcd commit 5c5ad29
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cpp/docs/TESTING.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Unit Testing in libcudf

Unit tests in libcudf are written using
[Google Test](https://github.com/google/googletest/blob/master/googletest/docs/primer.md).
[Google Test](https://github.com/google/googletest/blob/master/docs/primer.md).

**Important:** Instead of including `gtest/gtest.h` directly, use
`#include <cudf_test/cudf_gtest.hpp>`.
Expand Down Expand Up @@ -59,7 +59,7 @@ files, and are therefore preferred in test code over `thrust::device_vector`.

## Base Fixture

All libcudf unit tests should make use of a GTest ["Test Fixture"](https://github.com/google/googletest/blob/master/googletest/docs/primer.md#test-fixtures-using-the-same-data-configuration-for-multiple-tests-same-data-multiple-tests).
All libcudf unit tests should make use of a GTest ["Test Fixture"](https://github.com/google/googletest/blob/master/docs/primer.md#test-fixtures-using-the-same-data-configuration-for-multiple-tests-same-data-multiple-tests).
Even if the fixture is empty, it should inherit from the base fixture `cudf::test::BaseFixture`
found in `include/cudf_test/base_fixture.hpp`. This ensures that RMM is properly initialized and
finalized. `cudf::test::BaseFixture` already inherits from `::testing::Test` and therefore it is
Expand All @@ -75,7 +75,7 @@ class MyTestFiture : public cudf::test::BaseFixture {...};
In general, libcudf features must work across all of the supported types (there are exceptions e.g.
not all binary operations are supported for all types). In order to automate the process of running
the same tests across multiple types, we use GTest's
[Typed Tests](https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#typed-tests).
[Typed Tests](https://github.com/google/googletest/blob/master/docs/advanced.md#typed-tests).
Typed tests allow you to write a test once and run it across a list of types.
For example:
Expand Down

0 comments on commit 5c5ad29

Please sign in to comment.