Skip to content

Commit

Permalink
Address the comments
Browse files Browse the repository at this point in the history
Signed-off-by: Firestarman <[email protected]>
  • Loading branch information
firestarman committed May 7, 2021
1 parent 494dc4f commit 5a7bf86
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion java/src/main/java/ai/rapids/cudf/Scalar.java
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ public static Scalar fromString(String value) {
/**
* Creates a null scalar of list type.
*
* Having this special API is because the element type is required to build an empty
* Having this special API because the element type is required to build an empty
* nested column as the underlying column of the list scalar.
*
* @param elementType the data type of the element in the list.
Expand Down
2 changes: 1 addition & 1 deletion java/src/main/native/src/ScalarJni.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ JNIEXPORT jlong JNICALL Java_ai_rapids_cudf_Scalar_makeListScalar(JNIEnv *env, j
cudf::jni::auto_set_device(env);
auto col_view = reinterpret_cast<cudf::column_view *>(view_handle);

// Instead of calling the `cudf::empyt_like` to create an empty column when `is_valid`
// Instead of calling the `cudf::empty_like` to create an empty column when `is_valid`
// is false, always passes the input view to the scalar, to avoid copying the column
// twice.
// Let the Java layer make sure the view is empty when `is_valid` is false.
Expand Down

0 comments on commit 5a7bf86

Please sign in to comment.