Skip to content

Commit

Permalink
remove commented out line
Browse files Browse the repository at this point in the history
  • Loading branch information
davidwendt committed Feb 14, 2024
1 parent ac74cff commit 59d5fd1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions cpp/benchmarks/string/copy_if_else.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ static void bench_copy(nvbench::state& state)

data_profile const str_profile = data_profile_builder().distribution(
cudf::type_id::STRING, distribution_id::NORMAL, 0, row_width);
//.no_validity();
auto const source_table =
create_random_table({cudf::type_id::STRING}, row_count{num_rows}, str_profile);
auto const target_table =
Expand All @@ -53,7 +52,7 @@ static void bench_copy(nvbench::state& state)
state.add_global_memory_writes<nvbench::int8_t>(chars_size); // both columns are similar size

state.exec(nvbench::exec_tag::sync, [&](nvbench::launch& launch) {
auto result = cudf::copy_if_else(source, target, left_right);
[[maybe_unused]] auto result = cudf::copy_if_else(source, target, left_right);
});
}

Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cudf/strings/detail/copy_if_else.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ std::unique_ptr<cudf::column> copy_if_else(StringIterLeft lhs_begin,

// build vector of strings
rmm::device_uvector<string_index_pair> indices(strings_count, stream);
thrust::transform(rmm::exec_policy(stream),
thrust::transform(rmm::exec_policy_nosync(stream),
thrust::make_counting_iterator<size_type>(0),
thrust::make_counting_iterator<size_type>(strings_count),
indices.begin(),
Expand Down

0 comments on commit 59d5fd1

Please sign in to comment.