Skip to content

Commit

Permalink
Use file(COPY ) over file(INSTALL ) so cmake output is reduced (#7616)
Browse files Browse the repository at this point in the history
Currently it can be hard to see important details in cudf CMake output. The biggest culprit is the usage of `file(INSTALL` which outputs per file the current status on each configuration, as shown below:
```
- Up-to-date: /home/nfs/rmaynard/Work/cudf/cpp/build/cuda-11.0/branch-0.19/release/include/libcxx/include/<file.h>
```
Moving to `file(COPY` has all the same behavior but doesn't have any output.

Authors:
  - Robert Maynard (@robertmaynard)

Approvers:
  - Keith Kraus (@kkraus14)

URL: #7616
  • Loading branch information
robertmaynard authored Mar 17, 2021
1 parent 2b2c0d2 commit 57a7a8f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cpp/cmake/Modules/StringifyJITHeaders.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -164,5 +164,5 @@ add_custom_target(stringify_run DEPENDS
# - copy libcu++ ----------------------------------------------------------------------------------

# `${LIBCUDACXX_INCLUDE_DIR}/` specifies that the contents of this directory will be installed (not the directory itself)
file(INSTALL "${LIBCUDACXX_INCLUDE_DIR}/" DESTINATION "${CUDF_GENERATED_INCLUDE_DIR}/include/libcudacxx")
file(INSTALL "${LIBCXX_INCLUDE_DIR}" DESTINATION "${CUDF_GENERATED_INCLUDE_DIR}/include/libcxx")
file(COPY "${LIBCUDACXX_INCLUDE_DIR}/" DESTINATION "${CUDF_GENERATED_INCLUDE_DIR}/include/libcudacxx")
file(COPY "${LIBCXX_INCLUDE_DIR}" DESTINATION "${CUDF_GENERATED_INCLUDE_DIR}/include/libcxx")

0 comments on commit 57a7a8f

Please sign in to comment.